You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by kelvinrutt <gi...@git.apache.org> on 2017/06/16 18:41:40 UTC

[GitHub] kafka pull request #3357: KAFKA-5413: Log cleaner fails due to large offset ...

GitHub user kelvinrutt opened a pull request:

    https://github.com/apache/kafka/pull/3357

    KAFKA-5413: Log cleaner fails due to large offset in segment file

    the contribution is my original work and I license the work to the project under the project's open source license.
    
    @junrao , I had already made the code change before your last comment.  I've done pretty much what you said, except that I've not used the current segment because I wasn't sure if it will always be available.
    I'm happy to change it if you prefer.
    I've run all the unit and integration tests which all passed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kelvinrutt/kafka kafka_5413_bugfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3357
    
----
commit 85d7024ea6bc67328a59b5cae3078fd4138df33f
Author: Kelvin Rutt <ru...@gmail.com>
Date:   2017-06-15T14:34:04Z

    Fix problem with log cleaner where index under reports

commit 1adcc8a04af56a02efbeb90874e0545036c1a316
Author: Kelvin Rutt <ru...@gmail.com>
Date:   2017-06-15T15:34:28Z

    Add comments and remove some unwanted code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3357: KAFKA-5413: Log cleaner fails due to large offset ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3357


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---