You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/19 00:35:16 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #9583: [mypy]
Enforcing typing for superset.migrations
codecov-io commented on issue #9583: [mypy] Enforcing typing for superset.migrations
URL: https://github.com/apache/incubator-superset/pull/9583#issuecomment-615992833
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9583?src=pr&el=h1) Report
> Merging [#9583](https://codecov.io/gh/apache/incubator-superset/pull/9583?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9583?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9583 +/- ##
==========================================
- Coverage 65.62% 65.48% -0.14%
==========================================
Files 574 574
Lines 30060 30079 +19
Branches 3054 3054
==========================================
- Hits 19726 19697 -29
- Misses 10150 10198 +48
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.21% <0.00%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9583?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/env.py](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9lbnYucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.93% <0.00%> (-0.16%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/9583/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9583?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9583?src=pr&el=footer). Last update [ea27e68...4e7c048](https://codecov.io/gh/apache/incubator-superset/pull/9583?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org