[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1000: MINIFICPP-1451: ThreadPoolAdjust test transiently failed on Windows CI

[GitBox <gi...@apache.org>]

fgerlits commented on a change in pull request #1000:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1000#discussion_r573610053



##########
File path: extensions/http-curl/tests/ThreadPoolAdjust.cpp
##########
@@ -31,9 +31,11 @@
 #include "processors/LogAttribute.h"
 #include "utils/IntegrationTestUtils.h"
 
+constexpr uint64_t INCREASED_WAITTIME_MSECS = DEFAULT_WAITTIME_MSECS * 1.5;
+
 class HttpTestHarness : public IntegrationBase {
  public:
-  HttpTestHarness() {
+  HttpTestHarness() : IntegrationBase(INCREASED_WAITTIME_MSECS) {

Review comment:
       I would hard-code the wait time value here instead of defining it as `DEFAULT_WAITTIME_MSECS * 1.5`, because I don't think we want this wait time to change if we change the default later.
   
   Also, since `wait_time_` is only used as a parameter to `verifyLogLinePresenceInPollTime()`, ie. it will stop waiting earlier if the log line is found earlier, we could make it longer, eg. 5 seconds or even 10 seconds. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org