You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/21 11:33:10 UTC

[GitHub] [airflow-site] feluelle opened a new pull request #362: Fix redirect to / and /docs endpoint for some versions

feluelle opened a new pull request #362:
URL: https://github.com/apache/airflow-site/pull/362


   Some versions like >=1.10.14 and >=2.0.0 don't get correctly redirected to its documentation page.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] mik-laj commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r553839861



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       I don't think I need redirection for all files for 1.10.14 and 2.0.0 releases. We only need one redirection of one address for Airflow 2.0. See: 
   https://github.com/apache/airflow-site/pull/362/files#r553838344
   
   As for Airflow 1.10.14, we introduced a new link structure before this version was released.
   ![Screenshot 2021-01-08 at 10 40 20](https://user-images.githubusercontent.com/12058428/104000075-07a70100-519e-11eb-8a90-811e36eef2ee.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] feluelle commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r546677862



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       So @ashb that > 1.10.10 was missing here was wrong, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] mik-laj commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r553838344



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -3,7 +3,7 @@ RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
 RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"
 RedirectMatch Permanent ^/((api|changelog|cli|concepts|errors|faq|genindex|http-routingtable|installation|integration|kubernetes|license|lineage|macros|metrics|plugins|privacy_notice|profiling|project|py-modindex|scheduler|search|security|start|timezone|tutorial|ui)(\.html)?)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/docs/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10|1.10.11|1.10.12|1.10.13|stable)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"
+RedirectMatch Permanent ^/docs/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10|1.10.11|1.10.12|1.10.13|1.10.14|2\.[0-9.]+|stable)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       I don't think we need redirects for all versions as we didn't publish these links before.
   
   The only problem is `https://airflow.apache.org/docs/2.0.0/` which was included in the latest release by mistake. The following solution seems to me to address our problem better.
   ```
   Redirect Permanent /docs/2.0.0/ https://airflow.apache.org/docs/apache-airflow/2.0.0/

##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       I don't think I need redirection for all files for 1.10.14 and 2.0.0 releases. We only need one redirection of one address for Airflow 2.0. See: 
   https://github.com/apache/airflow-site/pull/362/files#r553838344
   
   As for Airflow 1.10.14, we introduced a new link structure before this version was released.
   ![Screenshot 2021-01-08 at 10 40 20](https://user-images.githubusercontent.com/12058428/104000075-07a70100-519e-11eb-8a90-811e36eef2ee.png)
   

##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       Ahh. 1.10.14 is also affected by this problem, so we can use the following requests.
   ```
   RedirectMatch Permanent ^/docs/(1.10.14|2\.[0-9.]+)/$ "https://airflow.apache.org/docs/apache-airflow/$1"
   ```

##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       Ahh. 1.10.14 is also affected by this problem, so we can use the following requests.
   ```
   RedirectMatch Permanent ^/docs/(1.10.14|2\.[0-9.]+)/?$ "https://airflow.apache.org/docs/apache-airflow/$1"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] ashb commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r546659234



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,11 @@
+RedirectMatch Permanent ^/((1\.10\.[0-9]+|2\.[0-9.]+|stable)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"
+RedirectMatch Permanent ^/docs/((1\.10\.[0-9]+|2\.[0-9.]+|stable)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"
+
+# Airflow 1.10.x
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"

Review comment:
       These won't match anymore, as lines 1 and 2 take over. So I think these need to go first.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] mik-laj commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r546816731



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       I think only versions 1.10.1 to 1.10.6.
   https://github.com/apache/airflow-site/tree/f18ad1c764861e8b049391c7bf95f46a4adae916%5E




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] feluelle commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r553773275



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       WDYT? @mik-laj - pls re-review :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] feluelle commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r553772255



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       I reverted this change as I only want to address the actual issue I found. I think this works as expected.
   
   Only 1.10.14 and >= 2.0.0 was missing in the redirect from / to /docs/apache-airflow.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] mik-laj commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r553838344



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -3,7 +3,7 @@ RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
 RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"
 RedirectMatch Permanent ^/((api|changelog|cli|concepts|errors|faq|genindex|http-routingtable|installation|integration|kubernetes|license|lineage|macros|metrics|plugins|privacy_notice|profiling|project|py-modindex|scheduler|search|security|start|timezone|tutorial|ui)(\.html)?)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/docs/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10|1.10.11|1.10.12|1.10.13|stable)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"
+RedirectMatch Permanent ^/docs/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10|1.10.11|1.10.12|1.10.13|1.10.14|2\.[0-9.]+|stable)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       I don't think we need redirects for all versions as we didn't publish these links before.
   
   The only problem is `https://airflow.apache.org/docs/2.0.0/` which was included in the latest release by mistake. The following solution seems to me to address our problem better.
   ```
   Redirect Permanent /docs/2.0.0/ https://airflow.apache.org/docs/apache-airflow/2.0.0/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] mik-laj merged pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #362:
URL: https://github.com/apache/airflow-site/pull/362


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] mik-laj merged pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #362:
URL: https://github.com/apache/airflow-site/pull/362


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] feluelle commented on pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
feluelle commented on pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#issuecomment-748928143


   I think that should do it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] feluelle commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r553772255



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       I reverted this change as I only want to address the actual issue I found. I think this works as expected.
   
   Only 1.10.14 and >= 2.0.0 was missing in the redirect from /docs to /docs/apache-airflow.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] mik-laj commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r553844323



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       Ahh. 1.10.14 is also affected by this problem, so we can use the following requests.
   ```
   RedirectMatch Permanent ^/docs/(1.10.14|2\.[0-9.]+)/$ "https://airflow.apache.org/docs/apache-airflow/$1"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] feluelle commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r546676007



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,11 @@
+RedirectMatch Permanent ^/((1\.10\.[0-9]+|2\.[0-9.]+|stable)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"
+RedirectMatch Permanent ^/docs/((1\.10\.[0-9]+|2\.[0-9.]+|stable)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"
+
+# Airflow 1.10.x
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"

Review comment:
       okay, I reverted the order.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] mik-laj commented on a change in pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#discussion_r553844323



##########
File path: landing-pages/site/static/.htaccess
##########
@@ -1,9 +1,9 @@
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/rest-api-ref"
 RedirectMatch Permanent ^/docs/(stable|1.10.10)/(cli|macros)(\.html)?$ "https://airflow.apache.org/docs/apache-airflow/$1/$2-ref"
 RedirectMatch Permanent ^/((_api|_images|_modules|_sources|_static|howto)/.*)$ "https://airflow.apache.org/docs/apache-airflow/stable/$1"
-RedirectMatch Permanent ^/((1.10.1|1.10.2|1.10.3|1.10.4|1.10.5|1.10.6|1.10.7|1.10.8|1.10.9|1.10.10)/.*)$ "https://airflow.apache.org/docs/apache-airflow/$1"

Review comment:
       Ahh. 1.10.14 is also affected by this problem, so we can use the following requests.
   ```
   RedirectMatch Permanent ^/docs/(1.10.14|2\.[0-9.]+)/?$ "https://airflow.apache.org/docs/apache-airflow/$1"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] turbaszek commented on pull request #362: Fix redirect to / and /docs endpoint for some versions

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #362:
URL: https://github.com/apache/airflow-site/pull/362#issuecomment-756598830


   Does this mean we can close this one?
   https://github.com/apache/airflow/pull/13250


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org