You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "maxburke (via GitHub)" <gi...@apache.org> on 2023/03/02 23:23:42 UTC
[GitHub] [arrow-datafusion] maxburke opened a new pull request, #5461: Enable hash joins on FixedSizeBinary columns
maxburke opened a new pull request, #5461:
URL: https://github.com/apache/arrow-datafusion/pull/5461
This helps ameliorate the performance issues in #5456 though the correctness issues identified in that issue still exist.
Before:
```
358946 rows in set. Query took 356.370 seconds.
```
After:
```
358946 rows in set. Query took 2.073 seconds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5461: Enable hash joins on FixedSizeBinary columns
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5461:
URL: https://github.com/apache/arrow-datafusion/pull/5461#issuecomment-1453467086
Benchmark runs are scheduled for baseline = 8de7ea45e96bfc1931ae51acb5a3abed7511dc7b and contender = ac618f034f566719f0a76c28608529b0a455a1c1. ac618f034f566719f0a76c28608529b0a455a1c1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/df2b14278ae942d8b79f317b5e7b148a...4900a46b6d0a48498313fa71c9c3335c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a24cf90805ef44ac999105c994f4dbbc...fd73d158b96245d09a4797dd17ce01d6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ce8485960d3148688244b2009c76ab17...937465c8ba1e446eb400cdf0d9444a1f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/945e1340df034dc287aca16d317c804c...d80eba1756c8491580be3ebdbf0bda83/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5461: Enable hash joins on FixedSizeBinary columns
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5461:
URL: https://github.com/apache/arrow-datafusion/pull/5461#issuecomment-1453460232
Thanks @maxburke -- it may be worth looking into to adding tests for `FixedSizeBinary` this datatype too. It is currenly somewhat inconvenient to do so, but I am hoping to work on https://github.com/apache/arrow-datafusion/issues/5016 to make it easier to write
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5461: Enable hash joins on FixedSizeBinary columns
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5461:
URL: https://github.com/apache/arrow-datafusion/pull/5461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org