[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #858: DISPATCH-1779: initial http stats for http1 and http2 adaptors

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #858:
URL: https://github.com/apache/qpid-dispatch/pull/858#discussion_r499780559



##########
File path: src/adaptors/http1/http1_client.c
##########
@@ -1202,8 +1220,11 @@ uint64_t qdr_http1_client_core_link_deliver(qdr_http1_adaptor_t    *adaptor,
     _client_response_msg_t *rmsg = DEQ_TAIL(hreq->responses);
     assert(rmsg && rmsg->dlv == delivery);
 
-    if (!rmsg->dispo)
+    if (!rmsg->dispo) {
         rmsg->dispo = _encode_response_message(hreq, rmsg);
+        hreq->base.stop = qd_timer_now();

Review comment:
       Question: is the intention to end the timing duration at the point where the response message is completely encoded?   If so this may not be the correct place to stop the timer since _encode_response_message() may return zero (message incomplete).
   Other Q: is the timer expected to keep running across INFO responses?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org