[GitHub] [helix] xyuanlu commented on pull request #2410: use reconnect timeout for crud retry timeout

["xyuanlu (via GitHub)" <gi...@apache.org>]

xyuanlu commented on PR #2410:
URL: https://github.com/apache/helix/pull/2410#issuecomment-1474730742

   > The change LGTM but I have one basic question, so previously we used to have two knobs for "reconnect" and "retry" now we are combining both knobs. Now what if user doesn't want to retry the op if reconnect happens after suppose 5 mins? (previously user can set operationRetryTimeout lesser than 5 mins and op won't be retried right?)
   
   Thanks for the comments. OperationRetry depends on auto reconnect. As of now there is no use case of having 2 separate config. So I would prefer let keep the config "simple and stupid". Easier for user to use. :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org