You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2010/01/17 23:06:33 UTC

svn commit: r900227 - in /james/server/trunk: core-library/src/test/java/org/apache/james/test/mock/avalon/ pop3server-function/src/test/java/org/apache/james/pop3server/ remotemanager-function/src/test/java/org/apache/james/remotemanager/ user-library...

Author: norman
Date: Sun Jan 17 22:06:33 2010
New Revision: 900227

URL: http://svn.apache.org/viewvc?rev=900227&view=rev
Log:
fix some more warnings

Modified:
    james/server/trunk/core-library/src/test/java/org/apache/james/test/mock/avalon/MockServiceManager.java
    james/server/trunk/pop3server-function/src/test/java/org/apache/james/pop3server/POP3TestConfiguration.java
    james/server/trunk/remotemanager-function/src/test/java/org/apache/james/remotemanager/RemoteManagerTestConfiguration.java
    james/server/trunk/user-library/src/test/java/org/apache/james/vut/AbstractVirtualUserTableTest.java

Modified: james/server/trunk/core-library/src/test/java/org/apache/james/test/mock/avalon/MockServiceManager.java
URL: http://svn.apache.org/viewvc/james/server/trunk/core-library/src/test/java/org/apache/james/test/mock/avalon/MockServiceManager.java?rev=900227&r1=900226&r2=900227&view=diff
==============================================================================
--- james/server/trunk/core-library/src/test/java/org/apache/james/test/mock/avalon/MockServiceManager.java (original)
+++ james/server/trunk/core-library/src/test/java/org/apache/james/test/mock/avalon/MockServiceManager.java Sun Jan 17 22:06:33 2010
@@ -25,7 +25,7 @@
 
 public class MockServiceManager implements org.apache.avalon.framework.service.ServiceManager {
 
-    private HashMap m_serviceMap = new HashMap();
+    private HashMap<String,Object> m_serviceMap = new HashMap<String,Object>();
 
     public Object lookup(String serviceName) throws ServiceException {
         return m_serviceMap.get(serviceName);

Modified: james/server/trunk/pop3server-function/src/test/java/org/apache/james/pop3server/POP3TestConfiguration.java
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server-function/src/test/java/org/apache/james/pop3server/POP3TestConfiguration.java?rev=900227&r1=900226&r2=900227&view=diff
==============================================================================
--- james/server/trunk/pop3server-function/src/test/java/org/apache/james/pop3server/POP3TestConfiguration.java (original)
+++ james/server/trunk/pop3server-function/src/test/java/org/apache/james/pop3server/POP3TestConfiguration.java Sun Jan 17 22:06:33 2010
@@ -22,6 +22,7 @@
 import org.apache.commons.configuration.DefaultConfigurationBuilder;
 import org.apache.james.pop3server.core.CoreCmdHandlerLoader;
 
+@SuppressWarnings("serial")
 public class POP3TestConfiguration extends DefaultConfigurationBuilder {
 
     private int m_pop3ListenerPort;

Modified: james/server/trunk/remotemanager-function/src/test/java/org/apache/james/remotemanager/RemoteManagerTestConfiguration.java
URL: http://svn.apache.org/viewvc/james/server/trunk/remotemanager-function/src/test/java/org/apache/james/remotemanager/RemoteManagerTestConfiguration.java?rev=900227&r1=900226&r2=900227&view=diff
==============================================================================
--- james/server/trunk/remotemanager-function/src/test/java/org/apache/james/remotemanager/RemoteManagerTestConfiguration.java (original)
+++ james/server/trunk/remotemanager-function/src/test/java/org/apache/james/remotemanager/RemoteManagerTestConfiguration.java Sun Jan 17 22:06:33 2010
@@ -24,6 +24,7 @@
 import org.apache.commons.configuration.DefaultConfigurationBuilder;
 import org.apache.james.remotemanager.core.CoreCmdHandlerLoader;
 
+@SuppressWarnings("serial")
 public class RemoteManagerTestConfiguration extends DefaultConfigurationBuilder {
 
     private int m_remoteManagerListenerPort;

Modified: james/server/trunk/user-library/src/test/java/org/apache/james/vut/AbstractVirtualUserTableTest.java
URL: http://svn.apache.org/viewvc/james/server/trunk/user-library/src/test/java/org/apache/james/vut/AbstractVirtualUserTableTest.java?rev=900227&r1=900226&r2=900227&view=diff
==============================================================================
--- james/server/trunk/user-library/src/test/java/org/apache/james/vut/AbstractVirtualUserTableTest.java (original)
+++ james/server/trunk/user-library/src/test/java/org/apache/james/vut/AbstractVirtualUserTableTest.java Sun Jan 17 22:06:33 2010
@@ -50,19 +50,19 @@
     }
     
     protected void tearDown() throws Exception {
-        Map mappings = virtualUserTable.getAllMappings();
+        Map<String,Collection<String>> mappings = virtualUserTable.getAllMappings();
         
         if (mappings != null) {
-            Iterator mappingsIt = virtualUserTable.getAllMappings().keySet().iterator();
+            Iterator<String> mappingsIt = virtualUserTable.getAllMappings().keySet().iterator();
     
     
             while(mappingsIt.hasNext()) {
                 String key = mappingsIt.next().toString();
                 String args[] = key.split("@");
         
-                Collection map = (Collection) mappings.get(key);
+                Collection<String> map = mappings.get(key);
         
-                Iterator mapIt = map.iterator();
+                Iterator<String> mapIt = map.iterator();
         
                 while (mapIt.hasNext()) {
                     try {
@@ -109,11 +109,14 @@
                 return InetAddress.getLocalHost();
             }
 
+            
+            @SuppressWarnings("unchecked")
             public Collection findMXRecords(String hostname)
                     throws TemporaryResolutionException {
                 throw new UnsupportedOperationException("Should never be called");
             }
 
+            @SuppressWarnings("unchecked")
             public Collection findTXTRecords(String hostname) {
                 throw new UnsupportedOperationException("Should never be called");
             }
@@ -123,6 +126,7 @@
                 throw new UnsupportedOperationException("Should never be called");
             }
 
+            @SuppressWarnings("unchecked")
             public Iterator getSMTPHostAddresses(String domainName)
                     throws TemporaryResolutionException {
                 throw new UnsupportedOperationException("Should never be called");
@@ -323,7 +327,7 @@
             assertTrue("Add mapping",addMapping(null, aliasDomain, user2 + "@" + domain, ADDRESS_TYPE));
             assertTrue("Add aliasDomain mapping", addMapping(null, aliasDomain, domain, ALIASDOMAIN_TYPE));
         
-            Iterator mappings = virtualUserTable.getMappings(user, aliasDomain).iterator();
+            Iterator<String> mappings = virtualUserTable.getMappings(user, aliasDomain).iterator();
             assertEquals("Domain mapped as first ", mappings.next(), user + "@" + domain);
             assertEquals("Address mapped as second ", mappings.next(), user2 + "@" + domain);
             



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org