You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/17 20:20:24 UTC
[GitHub] [spark] DavidToneian opened a new pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
DavidToneian opened a new pull request #28559:
URL: https://github.com/apache/spark/pull/28559
This commit is published into the public domain.
### What changes were proposed in this pull request?
Some syntax issues in docstrings have been fixed.
### Why are the changes needed?
In some places, the documentation did not render as intended, e.g. parameter documentations were not formatted as such.
### Does this PR introduce any user-facing change?
Slight improvements in documentation.
### How was this patch tested?
Manual testing and `dev/lint-python` run. No new Sphinx warnings arise due to this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630531082
Merged to branch-3.0 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629908836
**[Test build #122776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122776/testReport)** for PR 28559 at commit [`982ce47`](https://github.com/apache/spark/commit/982ce47b51d44d442cd2d5feb62d1639fb4d98fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630105533
**[Test build #122802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122802/testReport)** for PR 28559 at commit [`239bf9c`](https://github.com/apache/spark/commit/239bf9c0d1ee20deb1705ce4c0658b64596a8e1e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28559:
URL: https://github.com/apache/spark/pull/28559#discussion_r426367501
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -2150,9 +2150,9 @@ def toDF(self, *cols):
@since(3.0)
def transform(self, func):
- """Returns a new class:`DataFrame`. Concise syntax for chaining custom transformations.
+ """Returns a new :class:`DataFrame`. Concise syntax for chaining custom transformations.
- :param func: a function that takes and returns a class:`DataFrame`.
+ :param func: a function that takes and returns a :class:`DataFrame`.
Review comment:
Could you fix `classification.py` and `regression.py`, too?
```
pyspark/ml/classification.py: To be mixed in with class:`pyspark.ml.JavaModel`
pyspark/ml/regression.py: To be mixed in with class:`pyspark.ml.JavaModel`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629855514
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630118191
Merged to master.
I will pick this up when RC is cut out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630105980
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629915341
**[Test build #122776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122776/testReport)** for PR 28559 at commit [`982ce47`](https://github.com/apache/spark/commit/982ce47b51d44d442cd2d5feb62d1639fb4d98fa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630119331
**[Test build #122802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122802/testReport)** for PR 28559 at commit [`239bf9c`](https://github.com/apache/spark/commit/239bf9c0d1ee20deb1705ce4c0658b64596a8e1e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629855660
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630105533
**[Test build #122802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122802/testReport)** for PR 28559 at commit [`239bf9c`](https://github.com/apache/spark/commit/239bf9c0d1ee20deb1705ce4c0658b64596a8e1e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629855660
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629909197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28559:
URL: https://github.com/apache/spark/pull/28559
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630119945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630105985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629915653
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] DavidToneian commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
DavidToneian commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630105526
@dongjoon-hyun Thanks for pointing those out, fixed in the new commit above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629907830
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629855514
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629915653
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629909197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-629908836
**[Test build #122776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122776/testReport)** for PR 28559 at commit [`982ce47`](https://github.com/apache/spark/commit/982ce47b51d44d442cd2d5feb62d1639fb4d98fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630118191
Merged to master.
I will pick this up to branch-3.0 when RC is cut out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28559: [SPARK-31739][PYSPARK][DOCS][MINOR] Fix docstring syntax issues and misplaced space characters.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28559:
URL: https://github.com/apache/spark/pull/28559#issuecomment-630119945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org