You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/21 14:33:59 UTC

[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1730: Load job configuration and error handler at task staging each time

TeslaCN opened a new pull request #1730:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1730


   Fixes #1544
   
   Changes proposed in this pull request:
   - `JobErrorHandler` implements `Closeable`. 
   - Load job configuration at the beginning of `ElasticJobExecutor#execute`
   - Lazy init instance of `JobErrorHandler` in `ElasticJobExecutor`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1730: Load job configuration and error handler at task staging each time

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1730:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1730#issuecomment-731588618


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=h1) Report
   > Merging [#1730](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=desc) (6ab06df) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/4669c95fd49ba1eca6571e751c39fb41232f91d9?el=desc) (4669c95) will **decrease** coverage by `0.16%`.
   > The diff coverage is `65.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1730      +/-   ##
   ============================================
   - Coverage     86.07%   85.91%   -0.17%     
     Complexity      105      105              
   ============================================
     Files           252      252              
     Lines          5682     5686       +4     
     Branches        878      880       +2     
   ============================================
   - Hits           4891     4885       -6     
   - Misses          477      486       +9     
   - Partials        314      315       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rror/handler/dingtalk/DingtalkJobErrorHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1kaW5ndGFsay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9lcnJvci9oYW5kbGVyL2Rpbmd0YWxrL0Rpbmd0YWxrSm9iRXJyb3JIYW5kbGVyLmphdmE=) | `90.19% <0.00%> (-4.45%)` | `0.00 <0.00> (ø)` | |
   | [...ob/error/handler/wechat/WechatJobErrorHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci13ZWNoYXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvZXJyb3IvaGFuZGxlci93ZWNoYXQvV2VjaGF0Sm9iRXJyb3JIYW5kbGVyLmphdmE=) | `91.89% <0.00%> (-5.73%)` | `0.00 <0.00> (ø)` | |
   | [...sphere/elasticjob/executor/ElasticJobExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1leGVjdXRvci9lbGFzdGljam9iLWV4ZWN1dG9yLWtlcm5lbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9leGVjdXRvci9FbGFzdGljSm9iRXhlY3V0b3IuamF2YQ==) | `87.50% <77.27%> (-3.62%)` | `0.00 <0.00> (ø)` | |
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=footer). Last update [4669c95...6ab06df](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] TeslaCN closed pull request #1730: Load job configuration and error handler at task staging each time

Posted by GitBox <gi...@apache.org>.
TeslaCN closed pull request #1730:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1730


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1730: Load job configuration and error handler at task staging each time

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1730:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1730#issuecomment-731588618


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=h1) Report
   > Merging [#1730](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=desc) (6ab06df) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/4669c95fd49ba1eca6571e751c39fb41232f91d9?el=desc) (4669c95) will **decrease** coverage by `0.16%`.
   > The diff coverage is `65.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1730      +/-   ##
   ============================================
   - Coverage     86.07%   85.91%   -0.17%     
     Complexity      105      105              
   ============================================
     Files           252      252              
     Lines          5682     5686       +4     
     Branches        878      880       +2     
   ============================================
   - Hits           4891     4885       -6     
   - Misses          477      486       +9     
   - Partials        314      315       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rror/handler/dingtalk/DingtalkJobErrorHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1kaW5ndGFsay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9lcnJvci9oYW5kbGVyL2Rpbmd0YWxrL0Rpbmd0YWxrSm9iRXJyb3JIYW5kbGVyLmphdmE=) | `90.19% <0.00%> (-4.45%)` | `0.00 <0.00> (ø)` | |
   | [...ob/error/handler/wechat/WechatJobErrorHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci13ZWNoYXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvZXJyb3IvaGFuZGxlci93ZWNoYXQvV2VjaGF0Sm9iRXJyb3JIYW5kbGVyLmphdmE=) | `91.89% <0.00%> (-5.73%)` | `0.00 <0.00> (ø)` | |
   | [...sphere/elasticjob/executor/ElasticJobExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1leGVjdXRvci9lbGFzdGljam9iLWV4ZWN1dG9yLWtlcm5lbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9leGVjdXRvci9FbGFzdGljSm9iRXhlY3V0b3IuamF2YQ==) | `87.50% <77.27%> (-3.62%)` | `0.00 <0.00> (ø)` | |
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=footer). Last update [4669c95...6ab06df](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1730: Load job configuration and error handler at task staging each time

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1730:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1730#issuecomment-731591972


   I see. The modification to ElasticJobExecutor is not elegant. I'm gonna find a more elegant way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org