You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/15 08:58:37 UTC
[GitHub] [cloudstack-primate] shwstppr opened a new pull request #111: [WIP
DO NOT MERGE] views: create network action
shwstppr opened a new pull request #111: [WIP DO NOT MERGE] views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111
Adds custom create network action.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #111: views:
create network action
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on issue #111: views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111#issuecomment-602400012
LGTM but requires fixes for shared network:
- non-shared network offerings listed
- dont' show the secondary vlan id, but show the dropdown and show only when one of the community/isolated selected
- project scope returns exception
@shwstppr

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #111: [WIP] views:
create network action
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #111: [WIP] views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111#issuecomment-595091839
@rhtyd addressed label. issue.
Actually it was addressed earlier itself, only the screenshots were old.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #111: [WIP] views:
create network action
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #111: [WIP] views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111#issuecomment-574602034
@rhtyd sure, will update you once ready. Later today or tomorrow morning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #111: [WIP] views:
create network action
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #111: [WIP] views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111#issuecomment-587304129
> @shwstppr general notes:
>
> * Avoid using `this.$t()` withing `<template>...`, just use `$t(...)`
>
> * For translation, simply use the API arg such as `zoneid`, instead of `label.zoneid` (we'll fix this to make translation keys consistent)
>
> * The tabbed layout makes the UI form wobbly, as switching between forms (with different heights), let's discuss later how this jumpy behaviour can be fixed
Except for tabbed UI rest of the functionality should be fine now. @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #111: [WIP] views:
create network action
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #111: [WIP] views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111#issuecomment-594436524
@shwstppr can you review this, address all the label/issues; we want to prefer using the API arg as the translatable string. Ping me when this is ready for review, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #111: [WIP DO NOT
MERGE] views: create network action
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #111: [WIP DO NOT MERGE] views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111#issuecomment-574592314
@shwstppr is it complete, ready for review/testing? If not can you ping me when it is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd merged pull request #111: views: create
network action
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #111: views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #111: [WIP] views:
create network action
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #111: [WIP] views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111#issuecomment-578066373
@shwstppr general notes:
- Avoid using `this.$t()` withing `<template>...`, just use `$t(...)`
- For translation, simply use the API arg such as `zoneid`, instead of `label.zoneid` (we'll fix this to make translation keys consistent)
- The tabbed layout makes the UI form wobbly, as switching between forms (with different heights), let's discuss later how this jumpy behaviour can be fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #111: views:
create network action
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #111: views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111#issuecomment-602425885
@rhtyd addressed issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #111: views: create
network action
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #111: views: create network action
URL: https://github.com/apache/cloudstack-primate/pull/111#issuecomment-602400012
LGTM but requires fixes for shared network:
- non-shared network offerings listed
- dont' show the secondary vlan id, but show the dropdown and show only when one of the community/isolated selected
- project scope returns exception
@shwstppr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services