You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by GitBox <gi...@apache.org> on 2021/10/02 11:53:53 UTC
[GitHub] [ant] twogee opened a new pull request #161: Use Jakarta EE
twogee opened a new pull request #161:
URL: https://github.com/apache/ant/pull/161
Java Mail became Jakarta Mail, and Ant should prepare for EOL of the former.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-939327416
I really prefer to make this two separate artifacts, one using javax.mail, the other one using jakarta.mail. Two jars, new artifactId for a new jar and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-953895701
@twogee while adding documentation I stumbled over `MailLogger` which uses `MimeMailer` internally (and that I forgot myself as well). It would be probably be a good target to adapt as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] twogee commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
twogee commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-942941930
@bodewig thanks again for helping with the confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] twogee edited a comment on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
twogee edited a comment on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-933617604
I believe this is a case of a clean change when only one of the two implementations is necessary (in contrast to the muddle of JAI vs ImageIO). The only situation where both are needed is for development, and fetch.xml covers that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-953881596
thank you @twogee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-932931398
There might be a way to reduce the code duplication between the two mailer classes, but that can be done as a refactoring later. Also we'll need a new POM and a new artifact to publish. I'll look into this after 1.10.12 is out.
The change to ClasspathUtils looks good, thank you, but is not really related to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] twogee commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
twogee commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-933617604
I believe this is a case of a clean change when only one of the two implementations is necessary (in contrast to the muddle of JAI vs ImageIO).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] twogee commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
twogee commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-954003877
Thanks for heads-up. I would like to avoid code duplication and move `getMailerImplementation()` to Mailer, or is there a better way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] twogee commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
twogee commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-933173752
Thanks @bodewig, I missed the POM part. There's no need for a separate POM: I propose bumping the version in the current POM and adding a profile that overrides the dependencies in case somebody prefers the old javax.mail; I will add the change if the proposal is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] twogee commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
twogee commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-936988039
I take back my previous proposal, I was thinking from a consumer POM perspective, which is incorrect. Marking MimeMailer as deprecated, hoping deprecated classes will be removed some day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig merged pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
bodewig merged pull request #161:
URL: https://github.com/apache/ant/pull/161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-954050214
Mailer sounds like a good location, I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-933179077
Personally I'd prefer two separate jars and two separate POMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] twogee commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
twogee commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-940404725
Thanks for the review, could you please confirm if my understanding is correct that packaging some classes twice is acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #161: Use Jakarta EE
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-940684141
I'm afraid we are talking past each other as I don't understand the question :-)
Current master creates ant-javamail.jar containing `MimeMailer` and its nested classes. I'd like to see the new `JakartaMailer` and its nested classes go into a separate jar named ant-jakartamail.jar (for example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org