You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/09/21 23:14:05 UTC

[jira] [Commented] (KAFKA-1888) Add a "rolling upgrade" system test

    [ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901420#comment-14901420 ] 

ASF GitHub Bot commented on KAFKA-1888:
---------------------------------------

GitHub user granders opened a pull request:

    https://github.com/apache/kafka/pull/229

    KAFKA-1888 [WIP]: rolling upgrade test

    @ewencp @gwenshap 
    This needs some refactoring to avoid the duplicated code between replication test and upgrade test, but in shape for initial feedback.
    
    I'm interested in feedback on the added `KafkaConfig` class and `kafka_props` file. This addition makes it:
    - easier to attach different configs to different nodes (e.g. during broker upgrade process)
    - easier to reason about the configuration of a particular node
    
    Notes:
    - in the default values in the KafkaConfig class, I removed many properties which were in kafka.properties before. This is because most of those properties were set to what is already the default value.
    - when running non-trunk VerifiableProducer, I append the trunk tools jar to the classpath, and run it with the non-trunk kafka-run-class.sh script

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/confluentinc/kafka KAFKA-1888-upgrade-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #229
    
----
commit 22eae20df7ced03ca49f2f97033c21809c19c2e9
Author: Geoff Anderson <ge...@confluent.io>
Date:   2015-09-02T23:24:01Z

    Added simple mechanism for setting version on a Kafka node. Also updated provisioning script to bring in kafka 0.8.2.1, and included simple sanity tests.

commit 1fe461d1e6a9aa28fa23ce61a85ad5722691e003
Author: Geoff Anderson <ge...@confluent.io>
Date:   2015-09-15T01:04:44Z

    Added sanity checks on VerifiableProducer - check that we can successfully start and produce on trunk and on 0.8.2.1

commit 06dcb337ced72876bc03d0242e88971ea4bf57a6
Author: Geoff Anderson <ge...@confluent.io>
Date:   2015-09-15T01:13:55Z

    Added versioning on console consumer service

commit 80cbe0a0b03411e43439cfedab4bb2b63b26f869
Author: Geoff Anderson <ge...@confluent.io>
Date:   2015-09-15T01:18:56Z

    Added versioning for verifiable producer, as well as recoverable log4j logging

commit 4b8cfc72cb00474f2072cc7bc3136151688277f3
Author: Geoff Anderson <ge...@confluent.io>
Date:   2015-09-15T01:23:32Z

    Updated Kafka to include versioning and use KafkaConfig class instead of properties template file, and added upgrade test

----


> Add a "rolling upgrade" system test
> -----------------------------------
>
>                 Key: KAFKA-1888
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1888
>             Project: Kafka
>          Issue Type: Improvement
>          Components: system tests
>            Reporter: Gwen Shapira
>             Fix For: 0.10.0.0
>
>         Attachments: KAFKA-1888_2015-03-23_11:54:25.patch
>
>
> To help test upgrades and compatibility between versions, it will be cool to add a rolling-upgrade test to system tests:
> Given two versions (just a path to the jars?), check that you can do a
> rolling upgrade of the brokers from one version to another (using clients from the old version) without losing data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)