You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/04 15:40:41 UTC
[GitHub] [incubator-seatunnel] EricGao888 opened a new pull request, #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
EricGao888 opened a new pull request, #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641
## Purpose of this pull request
* Still WIP, will update CI and docs, remove `Checkstyle` related stuff in the following commits.
* Add Spotless plugin to fix formatting and style errors automatically
* This PR closes: #2492
## Check list
* Still WIP, not verified yet.
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricGao888 commented on a diff in pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641#discussion_r982453340
##########
tools/style/eclipse.importorder:
##########
@@ -0,0 +1,23 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#Organize Import Order
+0=org.apache.seatunnel
+1=org.apache
+2=java
+3=javax
+4=org
+5=com
Review Comment:
Thanks for the suggestions. I will take a look and see whether we could add scala into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641#issuecomment-1257798402
This is a very helpful feature for us. @531651225 @legendtkl @TyrantLucifer @laglangyue @getChan @2013650523 @TaoZex @liugddx PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] FlechazoW commented on pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
FlechazoW commented on PR #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641#issuecomment-1379906898
Hi, @EricGao888 Is there any process here? If this is not convenient for you, I can continue to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricGao888 commented on pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641#issuecomment-1379913743
> Hi, @EricGao888 Is there any process here? If this is not convenient for you, I can continue to do this.
Hello @FlechazoW , thanks for reaching out. Recently I've been quite busy with something else. I would appreciated it if you could help continue to complete this work. BTW, the configuration of `ratchetFrom` in this PR may not function as expected. You may refer to https://github.com/diffplug/spotless/issues/710#issuecomment-1211495549 for a workaround. If possible, I suggest not using `ratchetFrom` and fix the legacy formatting errors once for all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] FlechazoW commented on pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
FlechazoW commented on PR #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641#issuecomment-1379922262
> > Hi, @EricGao888 Is there any process here? If this is not convenient for you, I can continue to do this.
>
> Hello @FlechazoW , thanks for reaching out. Recently I've been quite busy with something else. I would appreciated it if you could help continue to complete this work. BTW, the configuration of `ratchetFrom` in this PR may not function as expected. You may refer to [diffplug/spotless#710 (comment)](https://github.com/diffplug/spotless/issues/710#issuecomment-1211495549) for a workaround. If possible, I suggest not using `ratchetFrom` and fix the legacy formatting errors once for all.
Thanks for your advice, and I will perfect this as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricGao888 commented on pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641#issuecomment-1272754139
@ashulin Sorry for the late update, I add extra configurations for scala formatting configurations and rename the previous `eclipse.importorder` to `seatunnel.importorder`. BTW, I found there are lot of suppressions related to checkstyle, I suppose I need to remove them as well?
https://github.com/apache/incubator-seatunnel/blob/dev/tools/checkstyle/suppressions.xml
https://github.com/apache/incubator-seatunnel/blob/c29370a7b5bf6d70e4266b4b4b345e059a699148/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/client/EsRestClient.java#L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641#issuecomment-1277052344
@ashulin PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricGao888 closed pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
EricGao888 closed pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
URL: https://github.com/apache/incubator-seatunnel/pull/2641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricGao888 commented on pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641#issuecomment-1380665127
Closed due to https://github.com/apache/incubator-seatunnel/pull/2641#issuecomment-1379913743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641#discussion_r982446072
##########
tools/style/eclipse.importorder:
##########
@@ -0,0 +1,23 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#Organize Import Order
+0=org.apache.seatunnel
+1=org.apache
+2=java
+3=javax
+4=org
+5=com
Review Comment:
Can scala be added?
And change the file name to `seatunnel.importorder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2641: [Feature] [Style] Add Spotless plugin to fix formatting and style errors automatically
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2641:
URL: https://github.com/apache/incubator-seatunnel/pull/2641#issuecomment-1261718308
great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org