You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/07/18 10:02:58 UTC

[GitHub] [groovy] paulk-asert commented on a change in pull request #1317: GROOVY-8715: check array in ResolveVisitor.resolveToInner

paulk-asert commented on a change in pull request #1317:
URL: https://github.com/apache/groovy/pull/1317#discussion_r456773638



##########
File path: src/main/java/org/codehaus/groovy/control/ResolveVisitor.java
##########
@@ -1467,10 +1472,10 @@ public void visitClass(final ClassNode node) {
         }
 
         ClassNode sn = node.getUnresolvedSuperClass();
-        if (sn != null) resolveOrFail(sn, node, true);
+        if (sn != null) resolveOrFailPlus(sn, node);

Review comment:
       I think `resolveOrFailPlus` isn't a very meaningful name. Agreed the existing parameter is also confusing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org