[GitHub] [tomcat] pzygielo commented on pull request #312: Use StringBuilder instead of StringBuffer

[GitBox <gi...@apache.org>]

pzygielo commented on pull request #312:
URL: https://github.com/apache/tomcat/pull/312#issuecomment-653434713


   > and which `append(char)` might be wrong.
   
   I suppose, there is change in produced result
   ```
   (1)              retval.append("\\t");
   (2)              retval.append('\t');
   ```
   as in first case "\t" (i.e. two-char string: `\` followed by `t`) is appended, and in second case - tab character ('\t') is.
   Unfortunately I can't tell if there is test to validate what is expected as all smoke test jobs pass.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org