[GitHub] [bookkeeper] dlg99 commented on a diff in pull request #3901: Fix garbage collection blocked by runtime exception

["dlg99 (via GitHub)" <gi...@apache.org>]

dlg99 commented on code in PR #3901:
URL: https://github.com/apache/bookkeeper/pull/3901#discussion_r1159295327


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java:
##########
@@ -759,7 +759,7 @@ protected void extractMetaFromEntryLogs() throws EntryLogMetadataMapException {
                 } else {
                     entryLogMetaMap.put(entryLogId, entryLogMeta);
                 }
-            } catch (IOException e) {
+            } catch (IOException | RuntimeException e) {

Review Comment:
   what if the RuntimeException is thrown for a different reason and can't be that easily skipped
   I think it makes more sense to make EntryLogger.getEntryLogMetadata throw the IOException in this case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org