You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "moomindani (via GitHub)" <gi...@apache.org> on 2026/05/08 07:28:01 UTC
[PR] Fix DatabricksWorkflowTaskGroup leaking TaskGroupContext on internal exception [airflow]
moomindani opened a new pull request, #66582:
URL: https://github.com/apache/airflow/pull/66582
DatabricksWorkflowTaskGroup.__exit__ can raise mid-execution (for example
when a child task does not implement `_convert_to_databricks_workflow_task`).
Without try/finally, super().__exit__ never runs and the workflow group is
left on the global TaskGroupContext stack, breaking later DAGs with
`Cannot mix TaskGroups from different DAGs`.
Wrap the body of `__exit__` in try/finally so super().__exit__ is always
invoked and the context stack is cleaned up.
Picks up @ayudovin's earlier work in #55891 (closed by author with explicit
permission to take over) and adds a regression test that exercises the bug
path directly: an EmptyOperator (which lacks
`_convert_to_databricks_workflow_task`) is added inside the workflow body,
which makes `__exit__` raise mid-way; the test then asserts that
`TaskGroupContext._context` is empty, which fails on unfixed code and
passes on fixed code.
closes: #42164
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.7)
Generated-by: Claude Code (Opus 4.7) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DatabricksWorkflowTaskGroup leaking TaskGroupContext on internal exception [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #66582:
URL: https://github.com/apache/airflow/pull/66582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org