You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/23 17:57:46 UTC

[GitHub] [geode] pivotal-eshu commented on a change in pull request #5256: GEODE-8217: Deserialize attribute before update and remove.

pivotal-eshu commented on a change in pull request #5256:
URL: https://github.com/apache/geode/pull/5256#discussion_r444393667



##########
File path: extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
##########
@@ -231,6 +236,11 @@ public void setOwner(Object manager) {
     }
   }
 
+  @SuppressWarnings("deprecation")
+  private void setOwnerDeprecated(DeltaSessionManager sessionManager) {

Review comment:
       I think the method name does not reflect PreferDeserializedForm. It might be better to be explicit instead of using Deprecated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org