You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by liuyu000 <gi...@git.apache.org> on 2018/06/25 12:44:21 UTC

[GitHub] trafodion pull request #1621: [TRAFODION-3119] Add *Syntax Descriptions* for...

GitHub user liuyu000 opened a pull request:

    https://github.com/apache/trafodion/pull/1621

    [TRAFODION-3119] Add *Syntax Descriptions* for *LOAD Statement* and Fix Typos in *Trafodion SQL Reference Manual*

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liuyu000/trafodion LoadStatement

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1621
    
----
commit cc384c6bda7c78dde4ba8d1f106fa9430b339b17
Author: liu.yu <qw...@...>
Date:   2018-06-25T12:38:12Z

    [TRAFODION-3119] Add *Syntax Descriptions* for *LOAD Statement* and Fix Typos in *Trafodion SQL Reference Manual*

commit fa6004ad0e719461a0a65e49c6c041d7d72fb2a2
Author: liu.yu <qw...@...>
Date:   2018-06-25T12:43:29Z

    Fix a typo

----


---

[GitHub] trafodion pull request #1621: [TRAFODION-3119] Add *Syntax Descriptions* for...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/trafodion/pull/1621


---

[GitHub] trafodion pull request #1621: [TRAFODION-3119] Add *Syntax Descriptions* for...

Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1621#discussion_r197999855
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_utilities.adoc ---
    @@ -530,6 +536,10 @@ In this case, the elapsed time of using LOAD Statement without options is nearly
     using LOAD WITH REBUILD INDEXES, and the elapsed time of the former is less than the latter 
     if this CQD is turned ON.
     
    +** `UPSERT USING LOAD`
    ++
    +specifies that data is inserted into target tables using rowset inserts without transactions.
    --- End diff --
    
    Dank fuer Ihnen hervorragenden Rat. Ich will Ihre Vorschläge günstig aufnehmen. 😁


---

[GitHub] trafodion pull request #1621: [TRAFODION-3119] Add *Syntax Descriptions* for...

Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1621#discussion_r197890883
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_utilities.adoc ---
    @@ -530,6 +536,10 @@ In this case, the elapsed time of using LOAD Statement without options is nearly
     using LOAD WITH REBUILD INDEXES, and the elapsed time of the former is less than the latter 
     if this CQD is turned ON.
     
    +** `UPSERT USING LOAD`
    ++
    +specifies that data is inserted into target tables using rowset inserts without transactions.
    --- End diff --
    
    Maybe we could clarify this a bit more? We could mention that in this case we don't use the HBase bulk loader and instead insert the data, multiple rows at a time, using the regular HBase interface (Put).


---