[jira] [Commented] (MAPREDUCE-3562) Concurrency issues in MultipleOutputs,JobControl,Counters

["Harsh J (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285385#comment-13285385 ] 

Harsh J commented on MAPREDUCE-3562:
------------------------------------

Why do we need close() to be synchronized though? Per the javadocs, one is supposed to call it in the cleanup stages alone - which removes need for it to be synchronized in practice right? I also don't see benefit of calling close several time - that'd just be doing things wrong (i.e. a user issue)?

I didn't look at the other parts yet though.
                
> Concurrency issues in MultipleOutputs,JobControl,Counters
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-3562
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3562
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Ravi Teja Ch N V
>            Assignee: Ravi Teja Ch N V
>         Attachments: MAPREDUCE-3562.patch
>
>
> bq.MultipleOutputs 
>   The close of recordwriters should be synchronized. 
>   public void close() throws IOException, InterruptedException { 
>     for (RecordWriter writer : recordWriters.values()) { 
>       writer.close(context); 
> bq.JobControl.java 
>   the getters of the jobs to be synchronized. 
> bq.Counters.java 
>    makeEscapedCompactString to be made synchronized. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira