You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Vishal Suvagia via Review Board <no...@reviews.apache.org> on 2021/07/19 12:08:14 UTC

Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3342
    https://issues.apache.org/jira/browse/RANGER-3342


Repository: ranger


Description
-------

Currently the work directory for Ranger embedded server is not configurable.
Need to make the work directory configurable to a custom location so that user can customize if required.


Diffs
-----

  embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 137168259d9aa55548a3953aff7def6d7228a9e5 
  security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 


Diff: https://reviews.apache.org/r/73463/diff/1/


Testing
-------

Validated the changes locally.


Thanks,

Vishal Suvagia

Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/#review223253
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On July 20, 2021, 9:37 a.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73463/
> -----------------------------------------------------------
> 
> (Updated July 20, 2021, 9:37 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3342
>     https://issues.apache.org/jira/browse/RANGER-3342
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently the work directory for Ranger embedded server is not configurable.
> Need to make the work directory configurable to a custom location so that user can customize if required.
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 137168259d9aa55548a3953aff7def6d7228a9e5 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 
> 
> 
> Diff: https://reviews.apache.org/r/73463/diff/2/
> 
> 
> Testing
> -------
> 
> Validated the changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/
-----------------------------------------------------------

(Updated July 20, 2021, 9:37 a.m.)


Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Updated patch to address review comments.


Bugs: RANGER-3342
    https://issues.apache.org/jira/browse/RANGER-3342


Repository: ranger


Description
-------

Currently the work directory for Ranger embedded server is not configurable.
Need to make the work directory configurable to a custom location so that user can customize if required.


Diffs (updated)
-----

  embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 137168259d9aa55548a3953aff7def6d7228a9e5 
  security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 


Diff: https://reviews.apache.org/r/73463/diff/2/

Changes: https://reviews.apache.org/r/73463/diff/1-2/


Testing
-------

Validated the changes locally.


Thanks,

Vishal Suvagia

Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/#review223249
-----------------------------------------------------------


Ship it!




Ship It!

- Nitin Galave


On July 19, 2021, 12:08 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73463/
> -----------------------------------------------------------
> 
> (Updated July 19, 2021, 12:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3342
>     https://issues.apache.org/jira/browse/RANGER-3342
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently the work directory for Ranger embedded server is not configurable.
> Need to make the work directory configurable to a custom location so that user can customize if required.
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 137168259d9aa55548a3953aff7def6d7228a9e5 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 
> 
> 
> Diff: https://reviews.apache.org/r/73463/diff/1/
> 
> 
> Testing
> -------
> 
> Validated the changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/#review223243
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On July 19, 2021, 12:08 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73463/
> -----------------------------------------------------------
> 
> (Updated July 19, 2021, 12:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3342
>     https://issues.apache.org/jira/browse/RANGER-3342
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently the work directory for Ranger embedded server is not configurable.
> Need to make the work directory configurable to a custom location so that user can customize if required.
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 137168259d9aa55548a3953aff7def6d7228a9e5 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 
> 
> 
> Diff: https://reviews.apache.org/r/73463/diff/1/
> 
> 
> Testing
> -------
> 
> Validated the changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/#review223244
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On July 19, 2021, 12:08 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73463/
> -----------------------------------------------------------
> 
> (Updated July 19, 2021, 12:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3342
>     https://issues.apache.org/jira/browse/RANGER-3342
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently the work directory for Ranger embedded server is not configurable.
> Need to make the work directory configurable to a custom location so that user can customize if required.
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 137168259d9aa55548a3953aff7def6d7228a9e5 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 
> 
> 
> Diff: https://reviews.apache.org/r/73463/diff/1/
> 
> 
> Testing
> -------
> 
> Validated the changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73463/#review223246
-----------------------------------------------------------




embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
Lines 267 (patched)
<https://reviews.apache.org/r/73463/#comment312330>

    Consider replacing #267 with the following (to reuse config value already read):
      webappCtx.setWorkDir(workDirPath);



embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
Lines 270 (patched)
<https://reviews.apache.org/r/73463/#comment312331>

    Consider including value of workDirPath in the log message, to help troubleshooting:
      LOG.fine("Skipping to set tomcat server work directory, '" + workDirPath + "', as its is blank or directory does not exist.");


- Madhan Neethiraj


On July 19, 2021, 12:08 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73463/
> -----------------------------------------------------------
> 
> (Updated July 19, 2021, 12:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3342
>     https://issues.apache.org/jira/browse/RANGER-3342
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently the work directory for Ranger embedded server is not configurable.
> Need to make the work directory configurable to a custom location so that user can customize if required.
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 137168259d9aa55548a3953aff7def6d7228a9e5 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8842071982f7a5831db4dcbcffd00d6a22a6fb2c 
> 
> 
> Diff: https://reviews.apache.org/r/73463/diff/1/
> 
> 
> Testing
> -------
> 
> Validated the changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>