You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/06/01 15:34:07 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #4338: Move BooleanBufferBuilder and NullBufferBuilder to arrow_buffer

tustvold opened a new pull request, #4338:
URL: https://github.com/apache/arrow-rs/pull/4338

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   Manually creating a NullBuffer is cumbersome, moving the builders into arrow_buffer will allow defining more ergonomic constructors for these types
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   It removes the deprecated combine_option_bitmap
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] viirya commented on pull request #4338: Move BooleanBufferBuilder and NullBufferBuilder to arrow_buffer

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #4338:
URL: https://github.com/apache/arrow-rs/pull/4338#issuecomment-1572534047

   I don't need api change except for moving the two builders, is it right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4338: Move BooleanBufferBuilder and NullBufferBuilder to arrow_buffer

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4338:
URL: https://github.com/apache/arrow-rs/pull/4338#discussion_r1213346876


##########
arrow-buffer/src/builder/null.rs:
##########
@@ -128,10 +127,15 @@ impl NullBufferBuilder {
 
     /// Builds the null buffer and resets the builder.
     /// Returns `None` if the builder only contains `true`s.
-    pub fn finish(&mut self) -> Option<Buffer> {
-        let buf = self.bitmap_builder.take().map(Into::into);
+    pub fn finish(&mut self) -> Option<NullBuffer> {

Review Comment:
   As this was previously crate-private I took the opportunity to change the signature before it becomes public and changing would be a breaking change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #4338: Move BooleanBufferBuilder and NullBufferBuilder to arrow_buffer

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4338:
URL: https://github.com/apache/arrow-rs/pull/4338


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #4338: Move BooleanBufferBuilder and NullBufferBuilder to arrow_buffer

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4338:
URL: https://github.com/apache/arrow-rs/pull/4338#issuecomment-1572735363

   I removed the deprecated combine_option_bitmap as part of the move (as it depended on ArrayData)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org