[GitHub] [superset] hughhhh commented on a diff in pull request #22832: chore: Update typing for `Table` component

["hughhhh (via GitHub)" <gi...@apache.org>]

hughhhh commented on code in PR #22832:
URL: https://github.com/apache/superset/pull/22832#discussion_r1086045520


##########
superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx:
##########
@@ -302,7 +298,7 @@ export default function DrillDetailPane({
           recordCount={resultsPage?.total}
           usePagination
           loading={isLoading}
-          onChange={(pagination: TablePaginationConfig) =>

Review Comment:
   wouldn't we want to leave the annotations to make it more clear on what data is being passed from the function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org