[GitHub] [drill] paul-rogers commented on a change in pull request #2052: DRILL-7603 and DRILL-7604: Add schema, options to REST query

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #2052: DRILL-7603 and DRILL-7604: Add schema, options to REST query
URL: https://github.com/apache/drill/pull/2052#discussion_r407158975
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java
 ##########
 @@ -146,6 +164,40 @@ public static OptionValue create(AccessibleScopes type, String name, Object val,
     throw new IllegalArgumentException(String.format("Unsupported type %s", val.getClass()));
   }
 
+  private static OptionValue fromString(AccessibleScopes type, String name,
+      String val, OptionScope scope, Kind kind) {
+    val = val.trim();
 
 Review comment:
   No, we don't. However, added an argument check to enforce non-null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services