[GitHub] [iceberg] dramaticlly commented on a diff in pull request #7732: Spark 3.4: IcebergSource extends SessionConfigSupport

["dramaticlly (via GitHub)" <gi...@apache.org>]

dramaticlly commented on code in PR #7732:
URL: https://github.com/apache/iceberg/pull/7732#discussion_r1212280530


##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -2055,4 +2112,10 @@ private DeleteFile writeEqDeleteFile(Table table) {
       throw new RuntimeException(e);
     }
   }
+
+  private void createBranch(Table table, String branch) {

Review Comment:
   is this method used anywhere? I cannot find it



##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -1953,6 +1954,62 @@ public void testTableWithInt96Timestamp() throws IOException {
     }
   }
 
+  @Test
+  public void testSessionConfigSupport() throws IOException {

Review Comment:
   do we need to throw IOException here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org