You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/20 04:35:38 UTC
[GitHub] [spark] gengliangwang opened a new pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
gengliangwang opened a new pull request #30440:
URL: https://github.com/apache/spark/pull/30440
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
After https://github.com/apache/spark/pull/30260, there are some type conversions disallowed under ANSI mode.
We should tell users what they can do if they have to use the disallowed casting.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Make it more user-friendly.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-730845267
Since there is no alternative function for converting timestamp to numeric, I will work on another one before continuing this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732536775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733802592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733264415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30440:
URL: https://github.com/apache/spark/pull/30440#discussion_r530360448
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1876,6 +1894,35 @@ object AnsiCast {
case _ => false
}
+
+ def typeCheckFailureMessage(
+ from: DataType,
+ to: DataType,
+ fallbackConfKey: String,
+ fallbackConfValue: String): String =
+ (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString}.
+ | To convert values from ${from.catalogString} to ${to.catalogString}, you can use functions TIMESTAMP_SECONDS/TIMESTAMP_MILLIS/TIMESTAMP_MICROS instead.
+ |""".stripMargin
+
+ case (_: ArrayType, StringType) =>
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString} with ANSI mode on.
+ | If you have to cast ${from.catalogString} to ${to.catalogString}, you can use the function array_join or set $fallbackConfKey as $fallbackConfValue.
Review comment:
upper case the function nama?
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1876,6 +1894,35 @@ object AnsiCast {
case _ => false
}
+
+ def typeCheckFailureMessage(
+ from: DataType,
+ to: DataType,
+ fallbackConfKey: String,
+ fallbackConfValue: String): String =
+ (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString}.
+ | To convert values from ${from.catalogString} to ${to.catalogString}, you can use functions TIMESTAMP_SECONDS/TIMESTAMP_MILLIS/TIMESTAMP_MICROS instead.
+ |""".stripMargin
+
+ case (_: ArrayType, StringType) =>
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString} with ANSI mode on.
+ | If you have to cast ${from.catalogString} to ${to.catalogString}, you can use the function array_join or set $fallbackConfKey as $fallbackConfValue.
Review comment:
upper case the function name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733490070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30440:
URL: https://github.com/apache/spark/pull/30440#discussion_r529251244
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1783,6 +1798,14 @@ case class AnsiCast(child: Expression, dataType: DataType, timeZoneId: Option[St
override protected val ansiEnabled: Boolean = true
override def canCast(from: DataType, to: DataType): Boolean = AnsiCast.canCast(from, to)
+
+ // For now, this expression is only used in table insertion.
+ // If there are more scenarios for this expression, we should update the error message on type
Review comment:
nit: a unnecessary space found in `expression, we`
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -98,6 +98,19 @@ object Cast {
case _ => false
}
+ def typeCheckFailureMessage(from: DataType, to: DataType): String = (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString},
+ | you can enable the casting by setting ${SQLConf.LEGACY_ALLOW_CAST_NUMERIC_TO_TIMESTAMP.key}
+ | to true, but we strongly recommend using function TIMESTAMP_SECONDS/TIMESTAMP_MILLIS/TIMESTAMP_MICROS instead.
Review comment:
nit: `function` -> `functions`?
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1885,6 +1908,35 @@ object AnsiCast {
case _ => false
}
+
+ def typeCheckFailureMessage(
+ from: DataType,
+ to: DataType,
+ fallbackConfKey: String,
+ fallbackConfValue: String): String =
+ (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${from.catalogString}.
Review comment:
`from.catalogString` -> `to.catalogString` for the latter one.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1885,6 +1908,35 @@ object AnsiCast {
case _ => false
}
+
+ def typeCheckFailureMessage(
+ from: DataType,
+ to: DataType,
+ fallbackConfKey: String,
+ fallbackConfValue: String): String =
+ (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${from.catalogString}.
+ | We strongly recommend using function TIMESTAMP_SECONDS/TIMESTAMP_MILLIS/TIMESTAMP_MICROS instead.
Review comment:
How about describing it like `To convert values from ${...} to ${...}, you can use functions TIMESTAMP_SECONDS/TIMESTAMP_MILLIS/TIMESTAMP_MICROS instead.` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733636412
**[Test build #131756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131756/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732993024
**[Test build #131664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131664/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-730852349
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36003/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733767295
@maropu @cloud-fan Thanks for the review!
Merging to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-730846789
**[Test build #131399 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131399/testReport)** for PR 30440 at commit [`18cecbb`](https://github.com/apache/spark/commit/18cecbbdb9a0648c64ecee775c653b1599ed0732).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732958619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733419129
**[Test build #131721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131721/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733489487
**[Test build #131721 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131721/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732846706
**[Test build #131652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131652/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733637305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732955324
**[Test build #131652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131652/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733537202
**[Test build #131756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131756/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733264415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733490070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733819063
**[Test build #131777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131777/testReport)** for PR 30440 at commit [`acfa5d0`](https://github.com/apache/spark/commit/acfa5d02da384d4926b72d0accab031c851eb167).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733643830
**[Test build #131772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131772/testReport)** for PR 30440 at commit [`bb5b219`](https://github.com/apache/spark/commit/bb5b219e3a337a4dbdf6923c19734c2643acd1fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-730846807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733526016
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732993024
**[Test build #131664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131664/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30440:
URL: https://github.com/apache/spark/pull/30440#discussion_r530075609
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -98,6 +98,19 @@ object Cast {
case _ => false
}
+ def typeCheckFailureMessage(from: DataType, to: DataType): String = (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString},
+ | you can enable the casting by setting ${SQLConf.LEGACY_ALLOW_CAST_NUMERIC_TO_TIMESTAMP.key}
Review comment:
Can we do it first? then we don't need to change this part again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733726087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732314155
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36161/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732287079
**[Test build #131559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131559/testReport)** for PR 30440 at commit [`1100cc6`](https://github.com/apache/spark/commit/1100cc6547e47524dbbd70e76bb144f51d7fc302).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733576716
**[Test build #131764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131764/testReport)** for PR 30440 at commit [`bb5b219`](https://github.com/apache/spark/commit/bb5b219e3a337a4dbdf6923c19734c2643acd1fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733576716
**[Test build #131764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131764/testReport)** for PR 30440 at commit [`bb5b219`](https://github.com/apache/spark/commit/bb5b219e3a337a4dbdf6923c19734c2643acd1fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733537202
**[Test build #131756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131756/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733637305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30440:
URL: https://github.com/apache/spark/pull/30440#discussion_r529248836
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -98,6 +98,19 @@ object Cast {
case _ => false
}
+ def typeCheckFailureMessage(from: DataType, to: DataType): String = (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString},
+ | you can enable the casting by setting ${SQLConf.LEGACY_ALLOW_CAST_NUMERIC_TO_TIMESTAMP.key}
Review comment:
shall we remove `LEGACY_ALLOW_CAST_NUMERIC_TO_TIMESTAMP`? It's true by default and I don't see why it's needed since we have ansi mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733146882
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732333187
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732450305
**[Test build #131559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131559/testReport)** for PR 30440 at commit [`1100cc6`](https://github.com/apache/spark/commit/1100cc6547e47524dbbd70e76bb144f51d7fc302).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733202292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732333160
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36161/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733418918
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733700290
**[Test build #131777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131777/testReport)** for PR 30440 at commit [`acfa5d0`](https://github.com/apache/spark/commit/acfa5d02da384d4926b72d0accab031c851eb167).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-730846311
**[Test build #131399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131399/testReport)** for PR 30440 at commit [`18cecbb`](https://github.com/apache/spark/commit/18cecbbdb9a0648c64ecee775c653b1599ed0732).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733735868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733782603
**[Test build #131772 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131772/testReport)** for PR 30440 at commit [`bb5b219`](https://github.com/apache/spark/commit/bb5b219e3a337a4dbdf6923c19734c2643acd1fa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-730846800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733735868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733798905
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-730852343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #30440:
URL: https://github.com/apache/spark/pull/30440#discussion_r530097508
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -98,6 +98,19 @@ object Cast {
case _ => false
}
+ def typeCheckFailureMessage(from: DataType, to: DataType): String = (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString},
+ | you can enable the casting by setting ${SQLConf.LEGACY_ALLOW_CAST_NUMERIC_TO_TIMESTAMP.key}
Review comment:
Sure, I have just created https://github.com/apache/spark/pull/30493
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733726087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-730846311
**[Test build #131399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131399/testReport)** for PR 30440 at commit [`18cecbb`](https://github.com/apache/spark/commit/18cecbbdb9a0648c64ecee775c653b1599ed0732).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732451205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732974090
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732451205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733643830
**[Test build #131772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131772/testReport)** for PR 30440 at commit [`bb5b219`](https://github.com/apache/spark/commit/bb5b219e3a337a4dbdf6923c19734c2643acd1fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732958619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733510495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733202292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733700290
**[Test build #131777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131777/testReport)** for PR 30440 at commit [`acfa5d0`](https://github.com/apache/spark/commit/acfa5d02da384d4926b72d0accab031c851eb167).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733802592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732659270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732535861
**[Test build #131593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131593/testReport)** for PR 30440 at commit [`1100cc6`](https://github.com/apache/spark/commit/1100cc6547e47524dbbd70e76bb144f51d7fc302).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733146375
**[Test build #131664 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131664/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732503805
**[Test build #131593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131593/testReport)** for PR 30440 at commit [`1100cc6`](https://github.com/apache/spark/commit/1100cc6547e47524dbbd70e76bb144f51d7fc302).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732536775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732846706
**[Test build #131652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131652/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733811342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733833292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733643102
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733419129
**[Test build #131721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131721/testReport)** for PR 30440 at commit [`e762162`](https://github.com/apache/spark/commit/e762162311e04c20bb06f9a4735514547050b832).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733146882
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #30440:
URL: https://github.com/apache/spark/pull/30440#discussion_r529459190
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -98,6 +98,19 @@ object Cast {
case _ => false
}
+ def typeCheckFailureMessage(from: DataType, to: DataType): String = (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString},
+ | you can enable the casting by setting ${SQLConf.LEGACY_ALLOW_CAST_NUMERIC_TO_TIMESTAMP.key}
Review comment:
+1, we can have another PR for it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732659270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732503805
**[Test build #131593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131593/testReport)** for PR 30440 at commit [`1100cc6`](https://github.com/apache/spark/commit/1100cc6547e47524dbbd70e76bb144f51d7fc302).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #30440:
URL: https://github.com/apache/spark/pull/30440
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733510495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732287079
**[Test build #131559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131559/testReport)** for PR 30440 at commit [`1100cc6`](https://github.com/apache/spark/commit/1100cc6547e47524dbbd70e76bb144f51d7fc302).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732333187
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-733718755
**[Test build #131764 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131764/testReport)** for PR 30440 at commit [`bb5b219`](https://github.com/apache/spark/commit/bb5b219e3a337a4dbdf6923c19734c2643acd1fa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-732842384
@cloud-fan @maropu Thanks for the suggestions. I have addressed them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30440: [WIP] [SPARK-33496][SQL]Improve error message of ANSI explicit cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30440:
URL: https://github.com/apache/spark/pull/30440#issuecomment-730846800
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org