You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/11/22 19:04:30 UTC
Review Request 53996: GEODE-2136: Don't duplicate cookies in the http
response
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53996/
-----------------------------------------------------------
Review request for geode and Jason Huynh.
Repository: geode
Description
-------
We had some code that copied cookies from the request to the response.
That caused us to include a potentially stale cookie value in the
response.
Adding a unit test that we don't screw up the users cookies. I had to
bring in a dependency on httpunit, because the HttpTester with jetty is
not correctly parsing multiple Set-Cookie headers.
Diffs
-----
extensions/geode-modules-session/build.gradle f068ddef355a7483fc71b4b1665b2ae2b7312233
extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/filter/SessionCachingFilter.java 71aa7687ea00475b16cda8937463a88dc18ef568
extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java 76ecab3e18be20092f48a14f2ff49394285a7741
Diff: https://reviews.apache.org/r/53996/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 53996: GEODE-2136: Don't duplicate cookies in the
http response
Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53996/#review156609
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Huynh
On Nov. 22, 2016, 7:04 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53996/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2016, 7:04 p.m.)
>
>
> Review request for geode and Jason Huynh.
>
>
> Repository: geode
>
>
> Description
> -------
>
> We had some code that copied cookies from the request to the response.
> That caused us to include a potentially stale cookie value in the
> response.
>
> Adding a unit test that we don't screw up the users cookies. I had to
> bring in a dependency on httpunit, because the HttpTester with jetty is
> not correctly parsing multiple Set-Cookie headers.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/build.gradle f068ddef355a7483fc71b4b1665b2ae2b7312233
> extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/filter/SessionCachingFilter.java 71aa7687ea00475b16cda8937463a88dc18ef568
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java 76ecab3e18be20092f48a14f2ff49394285a7741
>
> Diff: https://reviews.apache.org/r/53996/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>