You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/01/10 20:26:10 UTC
[kudu-CR] [webserver] small font in the footer
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5670
Change subject: [webserver] small font in the footer
......................................................................
[webserver] small font in the footer
This is to have a proper separation between the contents of the page
and the footer when the proper HTML styling files are not available.
That's the scenario for dev builds run with no --webserver_doc_root set.
Change-Id: Icb8d48e90fb730631a0dfa4b55f16bd191d5310a
---
M src/kudu/server/server_base.cc
M src/kudu/server/webserver.cc
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/5670/1
--
To view, visit http://gerrit.cloudera.org:8080/5670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb8d48e90fb730631a0dfa4b55f16bd191d5310a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [webserver] small font in the footer
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [webserver] small font in the footer
......................................................................
Patch Set 1:
> > Or just set your $KUDU_HOME env var to your kudu checkout
> directory
> > if it bugs you?
>
> Yeah, that's what I do.
That's for the cases when the binary is run on other machine and sources are not available. OK, it seems this does not bring any value. Abandoning since in most cases having built-from-sources kudu-master and kudu-tserver binaries means the source files are around, and having this workaround does not make much sense to people.
--
To view, visit http://gerrit.cloudera.org:8080/5670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb8d48e90fb730631a0dfa4b55f16bd191d5310a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [webserver] small font in the footer
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [webserver] small font in the footer
......................................................................
Patch Set 1:
Does this change the look & feel when styles are enabled?
Should we just add a <style> section in the <head> of the generated HTML and put the more important style elements there?
--
To view, visit http://gerrit.cloudera.org:8080/5670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb8d48e90fb730631a0dfa4b55f16bd191d5310a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [webserver] small font in the footer
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change.
Change subject: [webserver] small font in the footer
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Icb8d48e90fb730631a0dfa4b55f16bd191d5310a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [webserver] small font in the footer
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [webserver] small font in the footer
......................................................................
Patch Set 1:
> Or just set your $KUDU_HOME env var to your kudu checkout directory
> if it bugs you?
Yeah, that's what I do.
--
To view, visit http://gerrit.cloudera.org:8080/5670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb8d48e90fb730631a0dfa4b55f16bd191d5310a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [webserver] small font in the footer
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [webserver] small font in the footer
......................................................................
Patch Set 1:
Or just set your $KUDU_HOME env var to your kudu checkout directory if it bugs you?
--
To view, visit http://gerrit.cloudera.org:8080/5670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb8d48e90fb730631a0dfa4b55f16bd191d5310a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No