[GitHub] [dubbo] guohao commented on a change in pull request #8584: When use delay to export service, catch the exception and log it.

[GitBox <gi...@apache.org>]

guohao commented on a change in pull request #8584:
URL: https://github.com/apache/dubbo/pull/8584#discussion_r699823763



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
##########
@@ -239,6 +239,16 @@ public synchronized void export() {
         }
     }
 
+    protected void doDelayExport() {
+        DELAY_EXPORT_EXECUTOR.schedule(() -> {
+            try {
+                doExport();
+            } catch (Exception e) {
+                logger.error(e);

Review comment:
       Add some brief info such as `logger.error("Export service ${foo} failed",e)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org