You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/23 06:55:50 UTC
[GitHub] [spark] itholic opened a new pull request, #38766: [MINOR][SQL] Fix error message for `UNEXPECTED_INPUT_TYPE`
itholic opened a new pull request, #38766:
URL: https://github.com/apache/spark/pull/38766
### What changes were proposed in this pull request?
This PR proposes to correct the minor syntax on error message for `UNEXPECTED_INPUT_TYPE`,
### Why are the changes needed?
Error message should be started with upper-case character, and clear to read.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
```
./build/sbt “sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*”
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38766: [MINOR][SQL] Fix error message for `UNEXPECTED_INPUT_TYPE`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38766:
URL: https://github.com/apache/spark/pull/38766#issuecomment-1325988492
+1, LGTM. Merged to master.
Thank you, @itholic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38766: [MINOR][SQL] Fix error message for `UNEXPECTED_INPUT_TYPE`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38766: [MINOR][SQL] Fix error message for `UNEXPECTED_INPUT_TYPE`
URL: https://github.com/apache/spark/pull/38766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38766: [MINOR][SQL] Fix error message for `UNEXPECTED_INPUT_TYPE`
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38766:
URL: https://github.com/apache/spark/pull/38766#discussion_r1030983768
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -399,7 +399,7 @@
},
"UNEXPECTED_INPUT_TYPE" : {
"message" : [
- "parameter <paramIndex> requires <requiredType> type, however, <inputSql> is of <inputType> type."
+ "Parameter <paramIndex> requires <requiredType> type, however <inputSql> is of type <inputType>."
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #38766: [MINOR][SQL] Fix error message for `UNEXPECTED_INPUT_TYPE`
Posted by GitBox <gi...@apache.org>.
itholic commented on PR #38766:
URL: https://github.com/apache/spark/pull/38766#issuecomment-1324635151
I made it into a separate PR from my other tasks although it's very small change, to avoid in case this error message affecting the tests on the original PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38766: [MINOR][SQL] Fix error message for `UNEXPECTED_INPUT_TYPE`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38766:
URL: https://github.com/apache/spark/pull/38766#discussion_r1030190319
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -399,7 +399,7 @@
},
"UNEXPECTED_INPUT_TYPE" : {
"message" : [
- "parameter <paramIndex> requires <requiredType> type, however, <inputSql> is of <inputType> type."
+ "Parameter <paramIndex> requires <requiredType> type, however <inputSql> is of type <inputType>."
Review Comment:
```suggestion
"Parameter <paramIndex> requires the <requiredType> type, however <inputSql> has the type <inputType>."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org