You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/27 16:44:47 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #8392: Try to fix flaky test in the InactiveTopicDeleteTest.java
315157973 opened a new pull request #8392:
URL: https://github.com/apache/pulsar/pull/8392
1)testTopicLevelInActiveTopicApi:The error is caused by `getInactiveTopicPolicies()`, due to the slow startup of the broker, the cache has not been initialized yet.
2)testTopicLevelInactivePolicyUpdateAndClean:We previously updated the event trigger timing of topic-policies. The update is triggered after the event is consumed. Therefore, it is not enough to judge that the policy in the cache is null. We need to sleep and wait for the event to be consumed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on a change in pull request #8392: Try to fix flaky test in the InactiveTopicDeleteTest.java
Posted by GitBox <gi...@apache.org>.
315157973 commented on a change in pull request #8392:
URL: https://github.com/apache/pulsar/pull/8392#discussion_r513141543
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java
##########
@@ -303,10 +303,10 @@ public void testTopicLevelInActiveTopicApi() throws Exception {
conf.setSystemTopicEnabled(true);
conf.setTopicLevelPoliciesEnabled(true);
super.baseSetup();
- //wait for init
- Thread.sleep(2000);
final String topicName = "persistent://prop/ns-abc/testMaxInactiveDuration-" + UUID.randomUUID().toString();
admin.topics().createPartitionedTopic(topicName, 3);
+ //wait for init
+ Thread.sleep(3000);
Review comment:
I added an api to determine whether the cache is initialized
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8392: Try to fix flaky test in the InactiveTopicDeleteTest.java
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8392:
URL: https://github.com/apache/pulsar/pull/8392
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on a change in pull request #8392: Try to fix flaky test in the InactiveTopicDeleteTest.java
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #8392:
URL: https://github.com/apache/pulsar/pull/8392#discussion_r512926267
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java
##########
@@ -303,10 +303,10 @@ public void testTopicLevelInActiveTopicApi() throws Exception {
conf.setSystemTopicEnabled(true);
conf.setTopicLevelPoliciesEnabled(true);
super.baseSetup();
- //wait for init
- Thread.sleep(2000);
final String topicName = "persistent://prop/ns-abc/testMaxInactiveDuration-" + UUID.randomUUID().toString();
admin.topics().createPartitionedTopic(topicName, 3);
+ //wait for init
+ Thread.sleep(3000);
Review comment:
Can we find a better solution here rather than `Thread.sleep`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8392: Try to fix flaky test in the InactiveTopicDeleteTest.java
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8392:
URL: https://github.com/apache/pulsar/pull/8392#issuecomment-717414650
The second problem has been fixed, the first one I will comment out some code to see what the real error is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8392: Try to fix flaky test in the InactiveTopicDeleteTest.java
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8392:
URL: https://github.com/apache/pulsar/pull/8392#issuecomment-717683670
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org