[GitHub] [camel-k] mertdotcc commented on a diff in pull request #4182: add startup probes into the health trait

["mertdotcc (via GitHub)" <gi...@apache.org>]

mertdotcc commented on code in PR #4182:
URL: https://github.com/apache/camel-k/pull/4182#discussion_r1150830799


##########
pkg/apis/camel/v1/trait/health.go:
##########
@@ -54,4 +54,19 @@ type HealthTrait struct {
 	ReadinessSuccessThreshold int32 `property:"readiness-success-threshold" json:"readinessSuccessThreshold,omitempty"`
 	// Minimum consecutive failures for the readiness probe to be considered failed after having succeeded.
 	ReadinessFailureThreshold int32 `property:"readiness-failure-threshold" json:"readinessFailureThreshold,omitempty"`
+
+	// Configures the startup probe for the integration container (default `true`).
+	StartupProbeEnabled *bool `property:"startup-probe-enabled" json:"startupProbeEnabled,omitempty"`

Review Comment:
   Sure, I was confused with this anyway. Could you explain why the liveness probe defaults to false but the readiness one defaults to true?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org