You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/27 03:16:16 UTC

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1413: [IOTDB-775] Add SQL of creating snapshot manually

qiaojialin commented on a change in pull request #1413:
URL: https://github.com/apache/incubator-iotdb/pull/1413#discussion_r446477345



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/constant/SQLConstant.java
##########
@@ -152,6 +152,8 @@ private SQLConstant() {
 
   public static final int TOK_SHOW_MERGE_STATUS = 87;
 
+  public static final int TOK_CREATE_SNAPSHOT = 88;

Review comment:
       ```suggestion
     public static final int TOK_CREATE_SCHEMA_SNAPSHOT = 88;
   ```

##########
File path: server/src/main/java/org/apache/iotdb/db/qp/Planner.java
##########
@@ -100,6 +100,7 @@ protected Operator logicalOptimize(Operator operator)
       case CLEAR_CACHE:
       case NULL:
       case SHOW_MERGE_STATUS:
+      case CREATE_SNAPSHOT:

Review comment:
       ```suggestion
         case CREATE_SCHEMA_SNAPSHOT:
   ```

##########
File path: server/src/main/java/org/apache/iotdb/db/qp/logical/Operator.java
##########
@@ -76,6 +76,6 @@ public String toString() {
     GRANT_WATERMARK_EMBEDDING, REVOKE_WATERMARK_EMBEDDING,
     TTL, DELETE_STORAGE_GROUP, LOAD_CONFIGURATION, SHOW, LOAD_FILES, REMOVE_FILE, MOVE_FILE, LAST, GROUP_BY_FILL,
     ALTER_TIMESERIES, FLUSH, MERGE, FULL_MERGE, CLEAR_CACHE,
-    SHOW_MERGE_STATUS
+    SHOW_MERGE_STATUS, CREATE_SNAPSHOT

Review comment:
       ```suggestion
       SHOW_MERGE_STATUS, CREATE_SCHEMA_SNAPSHOT
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org