You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/21 21:28:00 UTC
[jira] [Commented] (TINKERPOP-1864) Gremlin Python tests for
GraphSON 2.0 and 3.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519790#comment-16519790 ]
ASF GitHub Bot commented on TINKERPOP-1864:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/883
TINKERPOP-1864 Run python glv tests on GraphSON 2.0 and 3.0
https://issues.apache.org/jira/browse/TINKERPOP-1864
There was about a 10 second time increase for adding the additional test execution option. Seems worthwhile.
Builds with `mvn clean install -pl gremlin-python`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/883.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #883
----
commit 6bd3199967608b8f1fd66ac1c72ccbbce7b76418
Author: Stephen Mallette <sp...@...>
Date: 2018-06-21T21:24:58Z
TINKERPOP-1864 Run python glv tests on GraphSON 2.0 and 3.0
There was about a 10 second time increase for adding the additional test execution option. Seems worthwhile.
----
> Gremlin Python tests for GraphSON 2.0 and 3.0
> ---------------------------------------------
>
> Key: TINKERPOP-1864
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1864
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.3.1
> Reporter: stephen mallette
> Priority: Minor
>
> With TINKERPOP-1844 gremlin-python tests no longer run against GraphSON 2.0. They only run against 3.0. It would be good to include runs against 2.0 as well - that will come with some challenges because there are tests that simply can't run against 2.0 given its limitations. To some degree, we do get some confidence that 2.0 still works as the 3.2.x tests still run 2.0 and will continue to do so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)