You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/02/18 11:38:21 UTC

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2196: Full console: suppress new line when echo is disabled

apache-mynewt-bot commented on issue #2196: Full console: suppress new line when echo is disabled
URL: https://github.com/apache/mynewt-core/pull/2196#issuecomment-587419385
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### sys/console/full/include/console/console.h
   <details>
   
   ```diff
   @@ -62,7 +62,7 @@
    void console_blocking_mode(void);
    void console_non_blocking_mode(void);
    /**
   - * Switch console echo state for input data on (on != 0) or off ( on= 0) 
   + * Switch console echo state for input data on (on != 0) or off ( on= 0)
     *
     * @param on Let console know if it should echo the input (!= 0),
     *        or disable the echo (= 0).
   ```
   
   </details>
   
   #### sys/console/full/src/console.c
   <details>
   
   ```diff
   @@ -1160,8 +1160,7 @@
                    console_switch_to_prompt();
                    console_clear_line();
                } else {
   -                if (echo)
   -                {
   +                if (echo) {
                        console_filter_out('\r');
                        console_filter_out('\n');
                    }
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services