[GitHub] [kafka] gharris1727 commented on pull request #12826: Using Timer class to track expiry in IncrementalCooperativeAssignor

[GitBox <gi...@apache.org>]

gharris1727 commented on PR #12826:
URL: https://github.com/apache/kafka/pull/12826#issuecomment-1306029257

   @vamossagar12 Can you expand on the importance of this change?
   
   Is the single `long` with `0` as a sentinel any different in readability than a `Timer` object with `null` as a sentinel value?
   
   And are the improved monotonicity guarantees important to this use-case? As far as I can tell the rebalance delay value itself is purely advisory, and all that matters functionally is whether the timer is expired or not.
   
   Also: GitHub shows the removed lines in the diff, so it is more unclear to comment out the previous code than it is to remove it entirely before committing. You can always revert individual blocks locally with `git checkout HEAD^ -p`.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org