You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by lu...@apache.org on 2020/04/23 22:53:03 UTC

[asterixdb] branch master updated: [NO ISSUE] Fix log marker of insert

This is an automated email from the ASF dual-hosted git repository.

luochen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 93d3c91  [NO ISSUE] Fix log marker of insert
93d3c91 is described below

commit 93d3c91ae36b0440c6f0f79b16a63a3837b1bb56
Author: luochen <cl...@uci.edu>
AuthorDate: Wed Apr 15 21:55:06 2020 -0700

    [NO ISSUE] Fix log marker of insert
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    - Fix the log marker of the insert operator by ensuring
    that the downstream operator is opened after the log
    marker callback is set.
    
    Change-Id: I5f131f205465265ecd843b869478f7b48839c609
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/5825
    Reviewed-by: Luo Chen <cl...@uci.edu>
    Reviewed-by: Murtadha Hubail <mh...@apache.org>
    Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
 .../asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java
index 121b5b9..0bb42d4 100644
--- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java
+++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java
@@ -168,7 +168,6 @@ public class LSMPrimaryInsertOperatorNodePushable extends LSMIndexInsertUpdateDe
         flushedPartialTuples = false;
         accessor = new FrameTupleAccessor(inputRecDesc);
         writeBuffer = new VSizeFrame(ctx);
-        writer.open();
         indexHelper.open();
         index = indexHelper.getIndexInstance();
         IIndex indexForUniquessCheck;
@@ -183,6 +182,7 @@ public class LSMPrimaryInsertOperatorNodePushable extends LSMIndexInsertUpdateDe
                 PrimaryIndexLogMarkerCallback callback = new PrimaryIndexLogMarkerCallback((AbstractLSMIndex) index);
                 TaskUtil.put(ILogMarkerCallback.KEY_MARKER_CALLBACK, callback, ctx);
             }
+            writer.open();
             keySearchCmp =
                     BTreeUtils.getSearchMultiComparator(((ITreeIndex) index).getComparatorFactories(), frameTuple);
             searchPred = new RangePredicate(frameTuple, frameTuple, true, true, keySearchCmp, keySearchCmp, null, null);