You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/05 23:37:03 UTC
[GitHub] [cordova-android] jamesyoon11 opened a new pull request #1170: remove jcenter from gradles
jamesyoon11 opened a new pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
JFrog will sunset Bintray, JCenter, GoCenter, and ChartCenter on May 1st 2021 and it will affect cordova-android project.
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
This PR removes jcenter repository from all gradles and replace it with maven.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Create the android project and check if there is no jcenter in gradle files and it is built successfully.
```
npx cordova create SampleApp com.sample.app SampleApp
cd SampleApp/
npx cordova platform add android
```
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jamesyoon11 commented on pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
jamesyoon11 commented on pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#issuecomment-793236655
Need to wait until Jetbrain migrates trove4j to mavenCentral.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#issuecomment-794063002
> Need to wait until Jetbrain migrates trove4j to mavenCentral.
For reference: https://youtrack.jetbrains.com/issue/IDEA-261387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#issuecomment-793151187
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=h1) Report
> Merging [#1170](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=desc) (0104aa1) into [master](https://codecov.io/gh/apache/cordova-android/commit/3081e5e6e91c32e507423411196b184325baa935?el=desc) (3081e5e) will **decrease** coverage by `0.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1170 +/- ##
==========================================
- Coverage 71.80% 71.63% -0.18%
==========================================
Files 21 21
Lines 1745 1745
==========================================
- Hits 1253 1250 -3
- Misses 492 495 +3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1170/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `68.78% <0.00%> (-1.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=footer). Last update [3081e5e...0104aa1](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jyoon11 commented on a change in pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
jyoon11 commented on a change in pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#discussion_r589867405
##########
File path: bin/templates/project/build.gradle
##########
@@ -22,7 +22,8 @@ buildscript {
ext.kotlin_version = '1.3.50'
repositories {
google()
- jcenter()
+ // org.jetbrains.trove4j:trove4j:20160824.
+ maven { url 'https://repo.appspace.com/list/plugins-release/' }
Review comment:
I agree with you. @breautek I was feeling that it was a little too early to work on this. Let me close it now and may open it again in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on a change in pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#discussion_r589851657
##########
File path: bin/templates/project/build.gradle
##########
@@ -22,7 +22,8 @@ buildscript {
ext.kotlin_version = '1.3.50'
repositories {
google()
- jcenter()
+ // org.jetbrains.trove4j:trove4j:20160824.
+ maven { url 'https://repo.appspace.com/list/plugins-release/' }
Review comment:
Yes, I would prefer to wait. I don't like the idea of adding a whole repository just for one package, which could be difficult to remove later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#issuecomment-793151187
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=h1) Report
> Merging [#1170](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=desc) (0104aa1) into [master](https://codecov.io/gh/apache/cordova-android/commit/3081e5e6e91c32e507423411196b184325baa935?el=desc) (3081e5e) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1170 +/- ##
=======================================
Coverage 71.80% 71.80%
=======================================
Files 21 21
Lines 1745 1745
=======================================
Hits 1253 1253
Misses 492 492
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=footer). Last update [3081e5e...0104aa1](https://codecov.io/gh/apache/cordova-android/pull/1170?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jyoon11 commented on a change in pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
jyoon11 commented on a change in pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#discussion_r589832587
##########
File path: bin/templates/project/build.gradle
##########
@@ -22,7 +22,8 @@ buildscript {
ext.kotlin_version = '1.3.50'
repositories {
google()
- jcenter()
+ // org.jetbrains.trove4j:trove4j:20160824.
+ maven { url 'https://repo.appspace.com/list/plugins-release/' }
Review comment:
Yeah.. Actually, trove4j is used from com.android.tools.build.
```
> Could not find org.jetbrains.trove4j:trove4j:20160824.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/org/jetbrains/trove4j/trove4j/20160824/trove4j-20160824.pom
If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
Required by:
project : > com.android.tools.build:gradle:4.0.1 > com.android.tools.build:builder:4.0.1 > com.android.tools:sdk-common:27.0.1
```
https://android.googlesource.com/platform/tools/base/+/refs/heads/mirror-goog-studio-master-dev/sdk-common/build.gradle#34
And, it looks like trove4j has not been migrated to mavenCentral or other popular repository yet.
https://youtrack.jetbrains.com/issue/IDEA-261387
So, please let me know if we should wait until Jetbrain resolves it or if there is any concern to use the appspace maven repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] brodybits commented on a change in pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#discussion_r589807255
##########
File path: bin/templates/project/build.gradle
##########
@@ -22,7 +22,8 @@ buildscript {
ext.kotlin_version = '1.3.50'
repositories {
google()
- jcenter()
+ // org.jetbrains.trove4j:trove4j:20160824.
+ maven { url 'https://repo.appspace.com/list/plugins-release/' }
Review comment:
Can you explain this a little?
From a quick search it looks to me like trove4j is under LGPL, which we would rather avoid supporting in the core.
I think it would be ideal if this could be specified from a plugin rather than from cordova-android itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] brodybits commented on a change in pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#discussion_r589849423
##########
File path: bin/templates/project/build.gradle
##########
@@ -22,7 +22,8 @@ buildscript {
ext.kotlin_version = '1.3.50'
repositories {
google()
- jcenter()
+ // org.jetbrains.trove4j:trove4j:20160824.
+ maven { url 'https://repo.appspace.com/list/plugins-release/' }
Review comment:
Aargh. So it looks like this is needed by the Android SDK, nothing to do with Cordova. I would favor making the comment more descriptive, like this for example:
// This Maven URL is needed to find trove4a artifact for Android SDK ref:
// https://youtrack.jetbrains.com/issue/IDEA-261387
Or we could just wait for them to resolve the issue. It looks like JCenter will not be gone until February 2022 (next year):
https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jamesyoon11 closed pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
jamesyoon11 closed pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] brodybits commented on pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
brodybits commented on pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#issuecomment-794206871
FYI discussion already started in #1160. I just added "resolves #1160" to the description of this PR. Thanks again!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] brodybits commented on pull request #1170: remove jcenter from gradles
Posted by GitBox <gi...@apache.org>.
brodybits commented on pull request #1170:
URL: https://github.com/apache/cordova-android/pull/1170#issuecomment-793145076
Thanks for the contribution, I just requested a review from some other maintainers. I wonder if this should be considered a breaking change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org