[GitHub] [james-project] jeantil commented on a change in pull request #400: JAMES-3567 Distributed server should not depend on ActiveMQ

[GitBox <gi...@apache.org>]

jeantil commented on a change in pull request #400:
URL: https://github.com/apache/james-project/pull/400#discussion_r618750516



##########
File path: server/container/guice/cassandra-rabbitmq-guice/pom.xml
##########
@@ -156,6 +165,26 @@
             <groupId>${james.groupId}</groupId>
             <artifactId>james-server-guice-jmx</artifactId>
         </dependency>
+        <dependency>

Review comment:
       I feel there must be something wrong in the way we assemble servers. 
   
   Shouldn't these dependencies be in a common guice server definition ? (by these dependencies I mean the ones that are not specific to a particular storage technology. 
   
   I had a look and `james-server-guice-common` feels like a good candidate but for some reason it pulls in inmemory implementations of some components  such as `james-server-task-memory` `james-server-mailrepository-memory`

##########
File path: server/container/guice/cassandra-rabbitmq-guice/pom.xml
##########
@@ -110,10 +115,6 @@
             <artifactId>event-sourcing-event-store-memory</artifactId>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>${james.groupId}</groupId>

Review comment:
       If I understand correctly `jame-server-cassandra-guice` is in fact `jame-server-cassandra-activemq-guice` ?

##########
File path: server/container/guice/cassandra-rabbitmq-guice/pom.xml
##########
@@ -168,12 +197,48 @@
             <groupId>${james.groupId}</groupId>
             <artifactId>james-server-guice-webadmin</artifactId>
         </dependency>
+        <dependency>
+            <groupId>${james.groupId}</groupId>
+            <artifactId>james-server-guice-webadmin-data</artifactId>

Review comment:
       james-server-guice-webmin-common ? I'm not saying to change it for this PR but I think it would be interesting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org