[GitHub] ccollins476ad commented on issue #157: Make it easier to pin a version to a specific tag

[GitBox <gi...@apache.org>]

ccollins476ad commented on issue #157: Make it easier to pin a version to a specific tag
URL: https://github.com/apache/mynewt-newt/issues/157#issuecomment-380633837
 
 
   Unfortunately, this isn't as straightforward as I thought it would be.  Consider the following `project.yml` excerpt:
   
   ```
   repository.apache-mynewt-core:
       type: 'git'
       vers: 'efe8d5f6bc0719b5a1cbb1d3537edafe2bd1c854'
       url: 'git@github.com:apache/mynewt-core.git'
   ```
   
   The intent is for newt to checkout the `efe8d5` commit of the `mynewt-core` repo.  The problem with this approach is that an arbitrary commit like the one above doesn't correspond to a specific repo version.  Newt needs to know which version of each repo is installed for a number of reasons:
   * Calculate repo dependencies
   * Determine if the repo version is compatible with the version of newt being used.
   
   Currently, newt looks at the versions specified in `project.yml` to determine which repo versions are installed.  If the `project.yml` file doesn't specify actual versions, there is a problem.
   
   It is quite a big change, but I think the correct solution is for each repo to indicate its current version in a file (`version.yml`?).  The contents of this file would change as new versions are released.  Using this scheme, newt could determine which version a particular commit corresponds to by reading the version file after performing a `git checkout`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services