You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "lvyanquan (via GitHub)" <gi...@apache.org> on 2023/02/27 06:41:59 UTC
[GitHub] [hudi] lvyanquan opened a new pull request, #8055: [HUDI-4849][DOCS] Remove default value for mandatory record key field
lvyanquan opened a new pull request, #8055:
URL: https://github.com/apache/hudi/pull/8055
### Change Logs
Remove default value for mandatory record key field.
There is a jira [HUDI-4849](https://issues.apache.org/jira/browse/HUDI-4849) already before, and try to complete it.
### Impact
Docs update.
### Risk level (write none, low medium or high below)
low.
### Documentation Update
[create-table](https://hudi.apache.org/cn/docs/quick-start-guide#create-table) and [configurations](https://hudi.apache.org/cn/docs/basic_configurations)
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lvyanquan commented on a diff in pull request #8055: [HUDI-4849][DOCS] Remove default value for mandatory record key field
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on code in PR #8055:
URL: https://github.com/apache/hudi/pull/8055#discussion_r1118465246
##########
website/docs/basic_configurations.md:
##########
@@ -74,7 +74,7 @@ Options useful for writing tables via `write.format.option(...)`
> Record key field. Value to be used as the `recordKey` component of `HoodieKey`.
Actual value will be obtained by invoking .toString() on the field value. Nested fields can be specified using
the dot notation eg: `a.b.c`<br></br>
-> **Default Value**: uuid (Optional)<br></br>
+> **Default Value**: N/A (Required)<br></br>
> `Config Param: RECORDKEY_FIELD`<br></br>
Review Comment:
Sorry for this incorrect change, this configuration has not been changed in Flink and default value 'uuid' was removed since this [pr-6681](https://github.com/apache/hudi/pull/6681) in Spark.
##########
website/docs/basic_configurations.md:
##########
@@ -74,7 +74,7 @@ Options useful for writing tables via `write.format.option(...)`
> Record key field. Value to be used as the `recordKey` component of `HoodieKey`.
Actual value will be obtained by invoking .toString() on the field value. Nested fields can be specified using
the dot notation eg: `a.b.c`<br></br>
-> **Default Value**: uuid (Optional)<br></br>
+> **Default Value**: N/A (Required)<br></br>
> `Config Param: RECORDKEY_FIELD`<br></br>
Review Comment:
Sorry for this incorrect change, this configuration has not been changed in Flink but default value 'uuid' was removed since this [pr-6681](https://github.com/apache/hudi/pull/6681) in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lvyanquan commented on a diff in pull request #8055: [HUDI-4849][DOCS] Remove default value for mandatory record key field
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on code in PR #8055:
URL: https://github.com/apache/hudi/pull/8055#discussion_r1118465246
##########
website/docs/basic_configurations.md:
##########
@@ -74,7 +74,7 @@ Options useful for writing tables via `write.format.option(...)`
> Record key field. Value to be used as the `recordKey` component of `HoodieKey`.
Actual value will be obtained by invoking .toString() on the field value. Nested fields can be specified using
the dot notation eg: `a.b.c`<br></br>
-> **Default Value**: uuid (Optional)<br></br>
+> **Default Value**: N/A (Required)<br></br>
> `Config Param: RECORDKEY_FIELD`<br></br>
Review Comment:
Sorry for this incorrect change, this configuration has been changed in Flink and default value 'uuid' was removed since this [pr-6681](https://github.com/apache/hudi/pull/6681) in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lvyanquan commented on a diff in pull request #8055: [HUDI-4849][DOCS] Remove default value for mandatory record key field
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on code in PR #8055:
URL: https://github.com/apache/hudi/pull/8055#discussion_r1119746601
##########
website/docs/basic_configurations.md:
##########
@@ -74,7 +74,7 @@ Options useful for writing tables via `write.format.option(...)`
> Record key field. Value to be used as the `recordKey` component of `HoodieKey`.
Actual value will be obtained by invoking .toString() on the field value. Nested fields can be specified using
the dot notation eg: `a.b.c`<br></br>
-> **Default Value**: uuid (Optional)<br></br>
+> **Default Value**: N/A (Required)<br></br>
> `Config Param: RECORDKEY_FIELD`<br></br>
Review Comment:
I have checked again, Default value change of 'hoodie.datasource.write.recordkey.field' was introduced only in lately [release-0.13.0](https://github.com/apache/hudi/blob/release-0.13.0/hudi-common/src/main/java/org/apache/hudi/keygen/constant/KeyGeneratorOptions.java) and wasn't changed in [release-0.12.2](https://github.com/apache/hudi/blob/release-0.12.2/hudi-common/src/main/java/org/apache/hudi/keygen/constant/KeyGeneratorOptions.java).
so no more versions to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8055: [HUDI-4849][DOCS] Remove default value for mandatory record key field
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8055:
URL: https://github.com/apache/hudi/pull/8055#discussion_r1118411261
##########
website/docs/basic_configurations.md:
##########
@@ -74,7 +74,7 @@ Options useful for writing tables via `write.format.option(...)`
> Record key field. Value to be used as the `recordKey` component of `HoodieKey`.
Actual value will be obtained by invoking .toString() on the field value. Nested fields can be specified using
the dot notation eg: `a.b.c`<br></br>
-> **Default Value**: uuid (Optional)<br></br>
+> **Default Value**: N/A (Required)<br></br>
> `Config Param: RECORDKEY_FIELD`<br></br>
Review Comment:
The default primary key `uuid` is broken now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8055: [HUDI-4849][DOCS] Remove default value for mandatory record key field
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8055:
URL: https://github.com/apache/hudi/pull/8055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8055: [HUDI-4849][DOCS] Remove default value for mandatory record key field
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8055:
URL: https://github.com/apache/hudi/pull/8055#discussion_r1119501457
##########
website/docs/basic_configurations.md:
##########
@@ -74,7 +74,7 @@ Options useful for writing tables via `write.format.option(...)`
> Record key field. Value to be used as the `recordKey` component of `HoodieKey`.
Actual value will be obtained by invoking .toString() on the field value. Nested fields can be specified using
the dot notation eg: `a.b.c`<br></br>
-> **Default Value**: uuid (Optional)<br></br>
+> **Default Value**: N/A (Required)<br></br>
> `Config Param: RECORDKEY_FIELD`<br></br>
Review Comment:
Can we fix the other version also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org