You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/07/25 08:04:51 UTC
Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/
-----------------------------------------------------------
Review request for cloudstack and Nitin Mehta.
Bugs: CLOUDSTACK-3779
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3779: Support System vm scaling on VMWare
Marked the system template new system template as dynamicallyScalable
- handled upgrade case
- moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
server/src/com/cloud/hypervisor/HypervisorGuruBase.java 34584ab
server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
setup/db/db/schema-410to420.sql 664e9b0
Diff: https://reviews.apache.org/r/12937/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on
VMWare
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/#review24089
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On July 26, 2013, 8:41 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12937/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 8:41 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3779: Support System vm scaling on VMWare
>
> Marked the system template new system template as dynamicallyScalable
> - handled upgrade case
> - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
>
> This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
> engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
> engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
> engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd
> server/src/com/cloud/server/ManagementServerImpl.java 7ac1254
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
> setup/db/db/schema-410to420.sql 82ca403
>
> Diff: https://reviews.apache.org/r/12937/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on
VMWare
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/#review24104
-----------------------------------------------------------
Commit 2f369973e22441dbebabf8d0683ddec866bef72f in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2f36997 ]
CLOUDSTACK-3779: Support System vm scaling on VMWare
Marked the system template new system template as dynamicallyScalable
- handled upgrade case
- moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
Signed off by : Nitin Mehta<ni...@citrix.com>
- ASF Subversion and Git Services
On July 26, 2013, 8:41 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12937/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 8:41 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3779: Support System vm scaling on VMWare
>
> Marked the system template new system template as dynamicallyScalable
> - handled upgrade case
> - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
>
> This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
> engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
> engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
> engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd
> server/src/com/cloud/server/ManagementServerImpl.java 7ac1254
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
> setup/db/db/schema-410to420.sql 82ca403
>
> Diff: https://reviews.apache.org/r/12937/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on
VMWare
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/#review24081
-----------------------------------------------------------
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
<https://reviews.apache.org/r/12937/#comment47925>
Why do u need the java code for this ? This could be done by the sql query right
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/12937/#comment47927>
Why is this required ?
- Nitin Mehta
On July 26, 2013, 8:41 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12937/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 8:41 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3779: Support System vm scaling on VMWare
>
> Marked the system template new system template as dynamicallyScalable
> - handled upgrade case
> - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
>
> This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
> engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
> engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
> engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd
> server/src/com/cloud/server/ManagementServerImpl.java 7ac1254
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
> setup/db/db/schema-410to420.sql 82ca403
>
> Diff: https://reviews.apache.org/r/12937/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on
VMWare
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/#review24100
-----------------------------------------------------------
Commit 4d35d92208c9b63ca27c794508d4c534fa773078 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d35d92 ]
CLOUDSTACK-3779: Support System vm scaling on VMWare
Marked the system template new system template as dynamicallyScalable
- handled upgrade case
- moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
Signed off by : Nitin Mehta<ni...@citrix.com>
- ASF Subversion and Git Services
On July 26, 2013, 8:41 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12937/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 8:41 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3779: Support System vm scaling on VMWare
>
> Marked the system template new system template as dynamicallyScalable
> - handled upgrade case
> - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
>
> This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
> engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
> engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
> engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd
> server/src/com/cloud/server/ManagementServerImpl.java 7ac1254
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
> setup/db/db/schema-410to420.sql 82ca403
>
> Diff: https://reviews.apache.org/r/12937/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on
VMWare
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/
-----------------------------------------------------------
(Updated July 26, 2013, 8:41 a.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Changed the log message
Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3779: Support System vm scaling on VMWare
Marked the system template new system template as dynamicallyScalable
- handled upgrade case
- moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd
server/src/com/cloud/server/ManagementServerImpl.java 7ac1254
server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
setup/db/db/schema-410to420.sql 82ca403
Diff: https://reviews.apache.org/r/12937/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on
VMWare
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On July 26, 2013, 6:45 a.m., Nitin Mehta wrote:
> > engine/schema/src/com/cloud/vm/VMInstanceVO.java, line 149
> > <https://reviews.apache.org/r/12937/diff/2/?file=327891#file327891line149>
> >
> > we need to start showing it in response as well
I have changed the uservm view table to get the value from vm_instance. Please refer to the change in schema-410to420.sql https://reviews.apache.org/r/12937/diff/#9
> On July 26, 2013, 6:45 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/server/ManagementServerImpl.java, line 3749
> > <https://reviews.apache.org/r/12937/diff/2/?file=327896#file327896line3749>
> >
> > Will this block KVM upgrade when the system vms are stopped
This is a specific check for xenserver and running system vm. For KVM or other hypervisors condition will fail in first check itself.
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/#review23914
-----------------------------------------------------------
On July 26, 2013, 8:41 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12937/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 8:41 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3779: Support System vm scaling on VMWare
>
> Marked the system template new system template as dynamicallyScalable
> - handled upgrade case
> - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
>
> This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
> engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
> engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
> engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd
> server/src/com/cloud/server/ManagementServerImpl.java 7ac1254
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
> setup/db/db/schema-410to420.sql 82ca403
>
> Diff: https://reviews.apache.org/r/12937/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on
VMWare
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/#review23914
-----------------------------------------------------------
engine/schema/src/com/cloud/vm/VMInstanceVO.java
<https://reviews.apache.org/r/12937/#comment47765>
we need to start showing it in response as well
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/12937/#comment47762>
Will this block KVM upgrade when the system vms are stopped
server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/12937/#comment47763>
just say tools
- Nitin Mehta
On July 25, 2013, 10:45 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12937/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 10:45 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3779: Support System vm scaling on VMWare
>
> Marked the system template new system template as dynamicallyScalable
> - handled upgrade case
> - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
>
> This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
> engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
> engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
> engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd
> server/src/com/cloud/server/ManagementServerImpl.java 7ac1254
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
> setup/db/db/schema-410to420.sql 82ca403
>
> Diff: https://reviews.apache.org/r/12937/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on
VMWare
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/
-----------------------------------------------------------
(Updated July 25, 2013, 10:45 a.m.)
Review request for cloudstack and Nitin Mehta.
Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3779: Support System vm scaling on VMWare
Marked the system template new system template as dynamicallyScalable
- handled upgrade case
- moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd
server/src/com/cloud/server/ManagementServerImpl.java 7ac1254
server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
setup/db/db/schema-410to420.sql 82ca403
Diff: https://reviews.apache.org/r/12937/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on
VMWare
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/
-----------------------------------------------------------
(Updated July 25, 2013, 10:44 a.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Included check for system vm on xenserver and throwing an exception accordingly
Bugs: CLOUDSTACK-3779
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3779: Support System vm scaling on VMWare
Marked the system template new system template as dynamicallyScalable
- handled upgrade case
- moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd
server/src/com/cloud/server/ManagementServerImpl.java 7ac1254
server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
setup/db/db/schema-410to420.sql 82ca403
Diff: https://reviews.apache.org/r/12937/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on
VMWare
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/#review23831
-----------------------------------------------------------
Review 12937 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #35 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/35/
- Jenkins Cloudstack.org
On July 25, 2013, 6:04 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12937/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 6:04 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3779
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3779: Support System vm scaling on VMWare
>
> Marked the system template new system template as dynamicallyScalable
> - handled upgrade case
> - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
>
> This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d
> engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892
> engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991
> engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 34584ab
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
> setup/db/db/schema-410to420.sql 664e9b0
>
> Diff: https://reviews.apache.org/r/12937/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>