You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by us...@apache.org on 2024/01/09 20:05:40 UTC
(solr) branch main updated: Correct the log.error to include the file name instead of hard-coded … (#2186)
This is an automated email from the ASF dual-hosted git repository.
uschindler pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr.git
The following commit(s) were added to refs/heads/main by this push:
new a6b8fe43af4 Correct the log.error to include the file name instead of hard-coded … (#2186)
a6b8fe43af4 is described below
commit a6b8fe43af49366e221659b61eecbb7b248cc7ce
Author: Hamzeh Aldmour <42...@users.noreply.github.com>
AuthorDate: Tue Jan 9 23:05:33 2024 +0300
Correct the log.error to include the file name instead of hard-coded … (#2186)
* Correct the log.error to include the file name instead of hard-coded value
* Add entry in the CHANGES.txt file in the 9.5 section
* Update CHANGES.txt
---
solr/CHANGES.txt | 2 ++
.../core/src/java/org/apache/solr/search/function/FileFloatSource.java | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index d97f7dcd346..b4b75870505 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -134,6 +134,8 @@ Improvements
* SOLR-16397: The MERGEINDEXES v2 endpoint has been updated to be more REST-ful.
MERGEINDEXES is now available at `POST /api/cores/coreName/merge-indices` (Sanjay Dutt via Jason Gerlowski)
+* PR#2186: Include the external file name in the log instead of the hard-coded value in FileFloatSource.java. (Hamzeh Aldmour via Uwe Schindler)
+
Optimizations
---------------------
* SOLR-17084: LBSolrClient (used by CloudSolrClient) now returns the count of core tracked as not live AKA zombies
diff --git a/solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java b/solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java
index b7628fde606..7664a822bcb 100644
--- a/solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java
+++ b/solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java
@@ -307,7 +307,8 @@ public class FileFloatSource extends ValueSource {
} catch (Exception e) {
if (++otherErrors <= 10) {
log.error(
- "Error loading external value source + fileName + {}{}",
+ "Error loading external value source: {} {}{}",
+ fname,
e,
(otherErrors < 10 ? "" : "\tSkipping future errors for this file."));
}