You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/10/17 19:24:41 UTC
[kudu-CR] [java] Remove the kudu-jepsen -Pjepsen build flag
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11709
Change subject: [java] Remove the kudu-jepsen -Pjepsen build flag
......................................................................
[java] Remove the kudu-jepsen -Pjepsen build flag
This removes the “jepsen” property required to build
the kudu-jepsen module. This was added back when
the build was Java 7 compatible and kudu-jepsen
required Java 8. Now the build requires Java 8 and
removing this will ensure we don’t break compiling
kudu-jepsen.
Change-Id: I82ec4470c18fb44ae71e8f6439b10fb63dde9d50
---
M java/kudu-jepsen/build.gradle
1 file changed, 0 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11709/1
--
To view, visit http://gerrit.cloudera.org:8080/11709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82ec4470c18fb44ae71e8f6439b10fb63dde9d50
Gerrit-Change-Number: 11709
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Remove the kudu-jepsen -Pjepsen build flag
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11709 )
Change subject: [java] Remove the kudu-jepsen -Pjepsen build flag
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ec4470c18fb44ae71e8f6439b10fb63dde9d50
Gerrit-Change-Number: 11709
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 17 Oct 2018 19:30:36 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Remove the kudu-jepsen -Pjepsen build flag
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11709 )
Change subject: [java] Remove the kudu-jepsen -Pjepsen build flag
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ec4470c18fb44ae71e8f6439b10fb63dde9d50
Gerrit-Change-Number: 11709
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 17 Oct 2018 19:30:20 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Remove the kudu-jepsen -Pjepsen build flag
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11709 )
Change subject: [java] Remove the kudu-jepsen -Pjepsen build flag
......................................................................
[java] Remove the kudu-jepsen -Pjepsen build flag
This removes the “jepsen” property required to build
the kudu-jepsen module. This was added back when
the build was Java 7 compatible and kudu-jepsen
required Java 8. Now the build requires Java 8 and
removing this will ensure we don’t break compiling
kudu-jepsen.
Change-Id: I82ec4470c18fb44ae71e8f6439b10fb63dde9d50
Reviewed-on: http://gerrit.cloudera.org:8080/11709
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/kudu-jepsen/build.gradle
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Adar Dembo: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I82ec4470c18fb44ae71e8f6439b10fb63dde9d50
Gerrit-Change-Number: 11709
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Remove the kudu-jepsen -Pjepsen build flag
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [java] Remove the kudu-jepsen -Pjepsen build flag
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I82ec4470c18fb44ae71e8f6439b10fb63dde9d50
Gerrit-Change-Number: 11709
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Remove the kudu-jepsen -Pjepsen build flag
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11709 )
Change subject: [java] Remove the kudu-jepsen -Pjepsen build flag
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ec4470c18fb44ae71e8f6439b10fb63dde9d50
Gerrit-Change-Number: 11709
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 17 Oct 2018 20:41:02 +0000
Gerrit-HasComments: No