[GitHub] [kafka] showuon commented on a change in pull request #10946: KAFKA-12997: Expose the append time for batches from raft

[GitBox <gi...@apache.org>]

showuon commented on a change in pull request #10946:
URL: https://github.com/apache/kafka/pull/10946#discussion_r662082332



##########
File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##########
@@ -495,6 +506,10 @@ public int sizeInBytes() {
         public void release() {
             pool.release(initialBuffer);
         }
+
+        public long appendTimestamp() {
+            return data.firstBatch().maxTimestamp();

Review comment:
       I think we should document that "we only use the append time of the first batch" here, and append a `to-do` with KAFKA-13020 to make it clear.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org