[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #240: Add HiveCatalog implementation

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #240: Add HiveCatalog implementation
URL: https://github.com/apache/incubator-iceberg/pull/240#discussion_r298451617
 
 

 ##########
 File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
 ##########
 @@ -134,10 +136,11 @@ public void commit(TableMetadata base, TableMetadata metadata) {
                 Integer.MAX_VALUE,
                 storageDescriptor(metadata),
                 Collections.emptyList(),
-                new HashMap<>(),
+                Maps.newHashMap(),
                 null,
                 null,
-                ICEBERG_TABLE_TYPE_VALUE);
+            TableType.EXTERNAL_TABLE.toString());
+        tbl.getParameters().put("EXTERNAL", "TRUE"); // using the external table type also requires this
 
 Review comment:
   @aokolnychyi, this is a new fix to make tables external so that Iceberg manages the underlying location instead of Hive. In the previous version of this PR, using a managed table caused the table location to be moved during rename, which would break Iceberg metadata. You probably want to make sure you're using this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org