You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/18 18:14:50 UTC
[GitHub] [airflow] potiuk opened a new pull request #8437: Not pulling base
python images does not work for bugfixes
potiuk opened a new pull request #8437: Not pulling base python images does not work for bugfixes
URL: https://github.com/apache/airflow/pull/8437
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #8437: Not pulling
base python images does not work for bugfixes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8437: Not pulling base python images does not work for bugfixes
URL: https://github.com/apache/airflow/pull/8437#issuecomment-615924689
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=h1) Report
> Merging [#8437](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d61a476da3a649bf2c1d347b9cb3abc62eae3ce9&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8437 +/- ##
======================================
Coverage 6.23% 6.23%
======================================
Files 946 946
Lines 45663 45663
======================================
Hits 2846 2846
Misses 42817 42817
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=footer). Last update [d61a476...c56af80](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8437: Not pulling base python
images does not work for bugfixes
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8437: Not pulling base python images does not work for bugfixes
URL: https://github.com/apache/airflow/pull/8437#issuecomment-615919400
Small one. There was another bugfix update for base python image and I found out that not pulling those images is bad as you will use an old, previosly downloaded python image :( which means full rebuild. I have changed it now so when "force pull" is used the base python image is also downloaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #8437: Not pulling base
python images does not work for bugfixes
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8437: Not pulling base python images does not work for bugfixes
URL: https://github.com/apache/airflow/pull/8437#issuecomment-615924689
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=h1) Report
> Merging [#8437](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d61a476da3a649bf2c1d347b9cb3abc62eae3ce9&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8437 +/- ##
======================================
Coverage 6.23% 6.23%
======================================
Files 946 946
Lines 45663 45663
======================================
Hits 2846 2846
Misses 42817 42817
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=footer). Last update [d61a476...c56af80](https://codecov.io/gh/apache/airflow/pull/8437?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #8437: Not pulling base python
images does not work for bugfixes
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8437: Not pulling base python images does not work for bugfixes
URL: https://github.com/apache/airflow/pull/8437
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services