You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:51:25 UTC
[GitHub] [ofbiz-framework] fehnomenal opened a new pull request #220: Make latitude and longitude numeric fields for correct comparisons
fehnomenal opened a new pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220
Improved: Make the latitude and longitude fields of `GeoPoint` numeric
Explanation:
Before this commit both are stored as strings in the database and at least PostgreSQL does not correctly compare numeric strings. Tthey will be sorted lexically which was not correct with floats.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
mbrohl commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-850869743
@JacquesLeRoux doe we have a Jira for this change?
IMO this is not complete because there is no documentation / changelog for the database changes. Users who use the geolocation fields might come into trouble when updgrading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] hg-stolle commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
hg-stolle commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-678144625
Yes.
It is rendering something, but the longitude seems to be way off, because the shown location is somewhere near [Vladivostok](https://en.wikipedia.org/wiki/Vladivostok) in eastern Russia. However, the proper coordinates are listed there ("Breitengrad" is the German word for latitude, "Längengrad" is German for longitude) and they are correct, pointing to a location in France.
Here's what is rendered:
Not sure whether that is a problem with the JavaScript stuff that gets pulled in from Google or the fact that I am using the older Release 17.12 of OFBiz here with the changes of this pull request patched in. Vladivostok has nearly the same latitude as the `FrenchCustomer`, so half of it is right. I do not know why the longitude is way off though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-666306192
Hi fehnomenal,
Did you check the implications on the other locations in code where latitude and longitude are used?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-850938934
Hi Michael,
I thought about creating a Jira but did not. I did not thought about the DB changes, too. You are right, I'll, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-671840152
Hi fehnomenal,
From https://github.com/fehnomenal/ofbiz-framework/tree/numeric-latlon I guess you used trunk. I did the same locally and createPartyPostalAddress worked correctly. You can see the stack trace below, Look for
Sync service [webtools/createPartyPostalAddress] finished in [766] milliseconds
2020-08-10 18:42:11,946 |jsse-nio-8443-exec-4 |ControlServlet |T| [[[webtools::runService (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:11,989 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.0s, 0 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-08-10 18:42:11,990 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.019s, 51 requests, 21 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-08-10 18:42:12,000 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.001s, 26 requests, 10 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/portal-controller.xml
2020-08-10 18:42:12,010 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.0s, 30 requests, 13 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/security-controller.xml
2020-08-10 18:42:12,021 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.001s, 5 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/tempexpr-controller.xml
2020-08-10 18:42:12,022 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.063s, 121 requests, 79 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/webapp/webtools/WEB-INF/controller.xml
2020-08-10 18:42:12,025 |jsse-nio-8443-exec-4 |RequestHandler |I| Rendering View [runService]. Hidden sessionId by default.
2020-08-10 18:42:12,026 |jsse-nio-8443-exec-4 |ServiceDispatcher |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] milliseconds
2020-08-10 18:42:12,035 |jsse-nio-8443-exec-4 |ScreenFactory |I| Got 12 screens in 0.007s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/ServiceScreens.xml
2020-08-10 18:42:12,270 |jsse-nio-8443-exec-4 |ScreenFactory |I| Got 11 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/CommonScreens.xml
2020-08-10 18:42:12,275 |jsse-nio-8443-exec-4 |ScreenFactory |I| Got 26 screens in 0.004s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-08-10 18:42:12,392 |jsse-nio-8443-exec-4 |ScreenFactory |I| Got 25 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-08-10 18:42:12,438 |jsse-nio-8443-exec-4 |ModelService |I| Set default value [SECURITY] for parameter [primaryPermission]
2020-08-10 18:42:12,445 |jsse-nio-8443-exec-4 |Log |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This simple-method-call is deprecated! Please use a service-call of genericBasePermissionC
heck instead.
2020-08-10 18:42:12,516 |jsse-nio-8443-exec-4 |ServiceDispatcher |T| Sync service [webtools/genericBasePermissionCheck] finished in [71] milliseconds
2020-08-10 18:42:12,517 |jsse-nio-8443-exec-4 |ServiceDispatcher |T| Sync service [webtools/securityPermissionCheck] finished in [79] milliseconds
2020-08-10 18:42:12,545 |jsse-nio-8443-exec-4 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:12,546 |jsse-nio-8443-exec-4 |ControlServlet |T| [[[webtools::runService (Domain:https://localhost)] Request Done- total:0.6,since last([webtools::runSer...):0.6]]
2020-08-10 18:42:16,899 |jsse-nio-8443-exec-6 |ControlServlet |T| [[[webtools::setSyncServiceParameters (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:16,903 |jsse-nio-8443-exec-6 |RequestHandler |I| Rendering View [setSyncServiceParameters]. Hidden sessionId by default.
2020-08-10 18:42:16,904 |jsse-nio-8443-exec-6 |ServiceDispatcher |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] milliseconds
2020-08-10 18:42:16,932 |jsse-nio-8443-exec-6 |ModelService |I| Set default value [SECURITY] for parameter [primaryPermission]
2020-08-10 18:42:16,933 |jsse-nio-8443-exec-6 |Log |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This simple-method-call is deprecated! Please use a service-call of genericBasePermissionC
heck instead.
2020-08-10 18:42:16,934 |jsse-nio-8443-exec-6 |ServiceDispatcher |T| Sync service [webtools/securityPermissionCheck] finished in [2] milliseconds
2020-08-10 18:42:16,948 |jsse-nio-8443-exec-6 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:16,951 |jsse-nio-8443-exec-6 |ControlServlet |T| [[[webtools::setSyncServiceParameters (Domain:https://localhost)] Request Done- total:0.052,since last([webtools::setSyn...):0.052]]
2020-08-10 18:42:17,714 |jsse-nio-8443-exec-7 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:17,716 |jsse-nio-8443-exec-7 |RequestHandler |I| [RequestHandler.doRequest]: Response is a chained request. Hidden sessionId by default.
2020-08-10 18:42:17,717 |jsse-nio-8443-exec-7 |RequestHandler |I| [RequestHandler]: Chain in place: requestUri=js overrideViewUri=null Hidden sessionId by default.
2020-08-10 18:42:17,717 |jsse-nio-8443-exec-7 |RequestHandler |I| Ran Event [java:org.apache.ofbiz.common.CommonEvents#jsResponseFromRequest] from [request], result is [success]
2020-08-10 18:42:17,718 |jsse-nio-8443-exec-7 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:17,719 |jsse-nio-8443-exec-7 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Done- total:0.005,since last([webtools::getJs ...):0.005]]
2020-08-10 18:42:32,567 |sse-nio-8443-exec-10 |ControlServlet |T| [[[webtools::runService (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:32,597 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.0s, 0 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-08-10 18:42:32,597 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.01s, 51 requests, 21 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-08-10 18:42:32,608 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.0s, 26 requests, 10 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/portal-controller.xml
2020-08-10 18:42:32,619 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.0s, 30 requests, 13 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/security-controller.xml
2020-08-10 18:42:32,629 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.0s, 5 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/tempexpr-controller.xml
2020-08-10 18:42:32,630 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.053s, 121 requests, 79 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/webapp/webtools/WEB-INF/controller.xml
2020-08-10 18:42:32,633 |sse-nio-8443-exec-10 |RequestHandler |I| Rendering View [runService]. Hidden sessionId by default.
2020-08-10 18:42:32,642 |sse-nio-8443-exec-10 |ScreenFactory |I| Got 12 screens in 0.005s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/ServiceScreens.xml
2020-08-10 18:42:32,871 |sse-nio-8443-exec-10 |ScreenFactory |I| Got 11 screens in 0.004s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/CommonScreens.xml
2020-08-10 18:42:32,876 |sse-nio-8443-exec-10 |ScreenFactory |I| Got 26 screens in 0.004s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-08-10 18:42:33,007 |sse-nio-8443-exec-10 |ScreenFactory |I| Got 25 screens in 0.022s from: file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-08-10 18:42:33,041 |sse-nio-8443-exec-10 |ModelService |I| Set default value [SECURITY] for parameter [primaryPermission]
2020-08-10 18:42:33,048 |sse-nio-8443-exec-10 |Log |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This simple-method-call is deprecated! Please use a service-call of genericBasePermissionC
heck instead.
2020-08-10 18:42:33,108 |sse-nio-8443-exec-10 |ServiceDispatcher |T| Sync service [webtools/genericBasePermissionCheck] finished in [60] milliseconds
2020-08-10 18:42:33,108 |sse-nio-8443-exec-10 |ServiceDispatcher |T| Sync service [webtools/securityPermissionCheck] finished in [67] milliseconds
2020-08-10 18:42:33,134 |sse-nio-8443-exec-10 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:33,136 |sse-nio-8443-exec-10 |ControlServlet |T| [[[webtools::runService (Domain:https://localhost)] Request Done- total:0.569,since last([webtools::runSer...):0.569]]
2020-08-10 18:42:35,852 |jsse-nio-8443-exec-8 |ControlServlet |T| [[[webtools::setSyncServiceParameters (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:35,856 |jsse-nio-8443-exec-8 |RequestHandler |I| Rendering View [setSyncServiceParameters]. Hidden sessionId by default.
2020-08-10 18:42:35,857 |jsse-nio-8443-exec-8 |ServiceDispatcher |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] milliseconds
2020-08-10 18:42:35,879 |jsse-nio-8443-exec-8 |ModelService |I| Set default value [SECURITY] for parameter [primaryPermission]
2020-08-10 18:42:35,880 |jsse-nio-8443-exec-8 |Log |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This simple-method-call is deprecated! Please use a service-call of genericBasePermissionC
heck instead.
2020-08-10 18:42:35,881 |jsse-nio-8443-exec-8 |ServiceDispatcher |T| Sync service [webtools/genericBasePermissionCheck] finished in [1] milliseconds
2020-08-10 18:42:35,881 |jsse-nio-8443-exec-8 |ServiceDispatcher |T| Sync service [webtools/securityPermissionCheck] finished in [2] milliseconds
2020-08-10 18:42:35,896 |jsse-nio-8443-exec-8 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:35,899 |jsse-nio-8443-exec-8 |ControlServlet |T| [[[webtools::setSyncServiceParameters (Domain:https://localhost)] Request Done- total:0.047,since last([webtools::setSyn...):0.047]]
2020-08-10 18:42:36,634 |jsse-nio-8443-exec-9 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:36,637 |jsse-nio-8443-exec-9 |RequestHandler |I| [RequestHandler.doRequest]: Response is a chained request. Hidden sessionId by default.
2020-08-10 18:42:36,637 |jsse-nio-8443-exec-9 |RequestHandler |I| [RequestHandler]: Chain in place: requestUri=js overrideViewUri=null Hidden sessionId by default.
2020-08-10 18:42:36,638 |jsse-nio-8443-exec-9 |RequestHandler |I| Ran Event [java:org.apache.ofbiz.common.CommonEvents#jsResponseFromRequest] from [request], result is [success]
2020-08-10 18:42:36,639 |jsse-nio-8443-exec-9 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:36,640 |jsse-nio-8443-exec-9 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Done- total:0.006,since last([webtools::getJs ...):0.006]]
2020-08-10 18:42:55,949 |jsse-nio-8443-exec-1 |ControlServlet |T| [[[webtools::scheduleServiceSync (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:55,980 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.0s, 0 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-08-10 18:42:55,981 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.01s, 51 requests, 21 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-08-10 18:42:55,990 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.0s, 26 requests, 10 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/portal-controller.xml
2020-08-10 18:42:55,999 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.0s, 30 requests, 13 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/security-controller.xml
2020-08-10 18:42:56,008 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.0s, 5 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/tempexpr-controller.xml
2020-08-10 18:42:56,009 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.048s, 121 requests, 79 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/webapp/webtools/WEB-INF/controller.xml
2020-08-10 18:42:56,096 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/partyContactMechPermissionCheck] finished in [83] milliseconds
2020-08-10 18:42:56,311 |jsse-nio-8443-exec-1 |UtilProperties |I| ResourceBundle ServiceUiLabels (fr) created in 0.036s with 4 properties
2020-08-10 18:42:56,311 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/createContactMech] finished in [52] milliseconds
2020-08-10 18:42:56,416 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/createPostalAddress] finished in [310] milliseconds
2020-08-10 18:42:56,750 |jsse-nio-8443-exec-1 |UtilProperties |I| ResourceBundle PartyEntityLabels (fr) created in 0.087s with 290 properties
2020-08-10 18:42:56,756 |jsse-nio-8443-exec-1 |Log |I| [PartyContactMechServices.xml#createPartyContactMech line 62] Creating a PartyContactMech with id: 111111
2020-08-10 18:42:56,778 |jsse-nio-8443-exec-1 |ServiceEcaCondition |W| doRealCompare returned null, returning false
2020-08-10 18:42:56,778 |jsse-nio-8443-exec-1 |ServiceEcaRule |I| For Service ECA [createPartyContactMech] on [commit] got false for condition: [contactMechPurposeTypeId][is-not-empty][true][String]
2020-08-10 18:42:56,778 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/createPartyContactMech] finished in [362] milliseconds
2020-08-10 18:42:56,778 |jsse-nio-8443-exec-1 |ServiceEcaCondition |W| doRealCompare returned null, returning false
2020-08-10 18:42:56,778 |jsse-nio-8443-exec-1 |ServiceEcaRule |I| For Service ECA [createPartyPostalAddress] on [commit] got false for condition: [paymentMethodId][is-not-empty][true][String]
2020-08-10 18:42:56,779 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/createPartyPostalAddress] finished in [766] milliseconds
2020-08-10 18:42:56,779 |jsse-nio-8443-exec-1 |RequestHandler |I| Ran Event [java:org.apache.ofbiz.webapp.event.CoreEvents#scheduleService] from [request], result is [sync_success]
2020-08-10 18:42:56,779 |jsse-nio-8443-exec-1 |RequestHandler |I| Rendering View [serviceResult]. Hidden sessionId by default.
2020-08-10 18:42:56,781 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] milliseconds
2020-08-10 18:42:56,789 |jsse-nio-8443-exec-1 |ScreenFactory |I| Got 12 screens in 0.005s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/ServiceScreens.xml
2020-08-10 18:42:56,922 |jsse-nio-8443-exec-1 |ScreenFactory |I| Got 11 screens in 0.004s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/CommonScreens.xml
2020-08-10 18:42:56,927 |jsse-nio-8443-exec-1 |ScreenFactory |I| Got 26 screens in 0.004s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-08-10 18:42:57,057 |jsse-nio-8443-exec-1 |ScreenFactory |I| Got 25 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-08-10 18:42:57,093 |jsse-nio-8443-exec-1 |ModelService |I| Set default value [SECURITY] for parameter [primaryPermission]
2020-08-10 18:42:57,099 |jsse-nio-8443-exec-1 |Log |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This simple-method-call is deprecated! Please use a service-call of genericBasePermissionC
heck instead.
2020-08-10 18:42:57,172 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/genericBasePermissionCheck] finished in [73] milliseconds
2020-08-10 18:42:57,173 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/securityPermissionCheck] finished in [80] milliseconds
2020-08-10 18:42:57,188 |jsse-nio-8443-exec-1 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:57,200 |jsse-nio-8443-exec-1 |ControlServlet |T| [[[webtools::scheduleServiceSync (Domain:https://localhost)] Request Done- total:1.251,since last([webtools::schedu...):1.251]]
2020-08-10 18:42:57,951 |jsse-nio-8443-exec-2 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:57,953 |jsse-nio-8443-exec-2 |RequestHandler |I| [RequestHandler.doRequest]: Response is a chained request. Hidden sessionId by default.
2020-08-10 18:42:57,954 |jsse-nio-8443-exec-2 |RequestHandler |I| [RequestHandler]: Chain in place: requestUri=js overrideViewUri=null Hidden sessionId by default.
2020-08-10 18:42:57,954 |jsse-nio-8443-exec-2 |RequestHandler |I| Ran Event [java:org.apache.ofbiz.common.CommonEvents#jsResponseFromRequest] from [request], result is [success]
2020-08-10 18:42:57,954 |jsse-nio-8443-exec-2 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:57,955 |jsse-nio-8443-exec-2 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Done- total:0.004,since last([webtools::getJs ...):0.004]]
I did not test the other services.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-665603293
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issue
s?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=220&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=220) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=220&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=220&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-677688170
Hi hg-stolle,
Could you do me a favour? Do you have a Google Maps account? If so, could you please check that
https://localhost:8443/partymgr/control/PartyGeoLocation?partyId=FrenchCustomer is rendering something accurate (it's my address), TIA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-678235415
Hi,
I checked using https://localhost:8443/partymgr/control/PartyGeoLocation?partyId=FrenchCustomer with trunk HEAD w/o this PR (220) being applied and I get the expected result:
So it seems this PR introduces some incompatible changes. Could you please verify? TIA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] hg-stolle commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
hg-stolle commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-677452602
@JacquesLeRoux:
> [...] and createPartyPostalAddress worked correctly.
So does this mean the changes can / will be merged? Or are there any showstoppers that prevent a merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
danwatford commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-848836469
Hi @JacquesLeRoux - I just tested PR 220, visiting the test URL https://localhost:8443/partymgr/control/PartyGeoLocation?partyId=FrenchCustomer, and the map appears to render correctly.
I couldn't figure out how to configure OFBiz with my Google API key so ended up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl line 44 with my key. Line 44 looked similar to:
`<script src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_" type="application/javascript"></script>`
Is there a way to configure ofbiz with the API key?
Any other screens I can test in order to progress this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] fehnomenal commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
fehnomenal commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-667881940
I did a quick check and found the following:
- Lat and lon are used in some places without problems (mainly inside calls to `UtilMisc.toMap` or simple outputs)
- Services `createPartyPostalAddress`, `createFacilityPostalAddress`, `updateFacilityPostalAddress` are broken with or without this change (apparently it calls `createGeoPoint` which claims `dataSourceId` is missing)
- Service `cdyneReturnCityState` fails because of missing parameter with no possibility to input it
- All other services related to geopoints do the right thing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-677665312
Hi hg-stolle,
Since createPartyPostalAddress is OK, I assume createFacilityPostalAddress and updateFacilityPostalAddress are OK too (did not check).
cdyneReturnCityState is indeed failing but this is an USA specific service and I'd not care about that if USA users are not.
I have still to check if appying this changes does not introduce issues and I'll do very soon...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux merged pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux edited a comment on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-671840152
Hi fehnomenal,
From https://github.com/fehnomenal/ofbiz-framework/tree/numeric-latlon I guess you used trunk. I did the same locally and createPartyPostalAddress worked correctly. You can see the stack trace below, Look for
Sync service [webtools/createPartyPostalAddress] finished in [766] milliseconds
```
2020-08-10 18:42:11,946 |jsse-nio-8443-exec-4 |ControlServlet |T| [[[webtools::runService (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:11,989 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.0s, 0 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-08-10 18:42:11,990 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.019s, 51 requests, 21 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-08-10 18:42:12,000 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.001s, 26 requests, 10 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/portal-controller.xml
2020-08-10 18:42:12,010 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.0s, 30 requests, 13 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/security-controller.xml
2020-08-10 18:42:12,021 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.001s, 5 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/tempexpr-controller.xml
2020-08-10 18:42:12,022 |jsse-nio-8443-exec-4 |ConfigXMLReader |I| controller loaded: 0.063s, 121 requests, 79 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/webapp/webtools/WEB-INF/controller.xml
2020-08-10 18:42:12,025 |jsse-nio-8443-exec-4 |RequestHandler |I| Rendering View [runService]. Hidden sessionId by default.
2020-08-10 18:42:12,026 |jsse-nio-8443-exec-4 |ServiceDispatcher |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] milliseconds
2020-08-10 18:42:12,035 |jsse-nio-8443-exec-4 |ScreenFactory |I| Got 12 screens in 0.007s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/ServiceScreens.xml
2020-08-10 18:42:12,270 |jsse-nio-8443-exec-4 |ScreenFactory |I| Got 11 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/CommonScreens.xml
2020-08-10 18:42:12,275 |jsse-nio-8443-exec-4 |ScreenFactory |I| Got 26 screens in 0.004s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-08-10 18:42:12,392 |jsse-nio-8443-exec-4 |ScreenFactory |I| Got 25 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-08-10 18:42:12,438 |jsse-nio-8443-exec-4 |ModelService |I| Set default value [SECURITY] for parameter [primaryPermission]
2020-08-10 18:42:12,445 |jsse-nio-8443-exec-4 |Log |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This simple-method-call is deprecated! Please use a service-call of genericBasePermissionC
heck instead.
2020-08-10 18:42:12,516 |jsse-nio-8443-exec-4 |ServiceDispatcher |T| Sync service [webtools/genericBasePermissionCheck] finished in [71] milliseconds
2020-08-10 18:42:12,517 |jsse-nio-8443-exec-4 |ServiceDispatcher |T| Sync service [webtools/securityPermissionCheck] finished in [79] milliseconds
2020-08-10 18:42:12,545 |jsse-nio-8443-exec-4 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:12,546 |jsse-nio-8443-exec-4 |ControlServlet |T| [[[webtools::runService (Domain:https://localhost)] Request Done- total:0.6,since last([webtools::runSer...):0.6]]
2020-08-10 18:42:16,899 |jsse-nio-8443-exec-6 |ControlServlet |T| [[[webtools::setSyncServiceParameters (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:16,903 |jsse-nio-8443-exec-6 |RequestHandler |I| Rendering View [setSyncServiceParameters]. Hidden sessionId by default.
2020-08-10 18:42:16,904 |jsse-nio-8443-exec-6 |ServiceDispatcher |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] milliseconds
2020-08-10 18:42:16,932 |jsse-nio-8443-exec-6 |ModelService |I| Set default value [SECURITY] for parameter [primaryPermission]
2020-08-10 18:42:16,933 |jsse-nio-8443-exec-6 |Log |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This simple-method-call is deprecated! Please use a service-call of genericBasePermissionC
heck instead.
2020-08-10 18:42:16,934 |jsse-nio-8443-exec-6 |ServiceDispatcher |T| Sync service [webtools/securityPermissionCheck] finished in [2] milliseconds
2020-08-10 18:42:16,948 |jsse-nio-8443-exec-6 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:16,951 |jsse-nio-8443-exec-6 |ControlServlet |T| [[[webtools::setSyncServiceParameters (Domain:https://localhost)] Request Done- total:0.052,since last([webtools::setSyn...):0.052]]
2020-08-10 18:42:17,714 |jsse-nio-8443-exec-7 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:17,716 |jsse-nio-8443-exec-7 |RequestHandler |I| [RequestHandler.doRequest]: Response is a chained request. Hidden sessionId by default.
2020-08-10 18:42:17,717 |jsse-nio-8443-exec-7 |RequestHandler |I| [RequestHandler]: Chain in place: requestUri=js overrideViewUri=null Hidden sessionId by default.
2020-08-10 18:42:17,717 |jsse-nio-8443-exec-7 |RequestHandler |I| Ran Event [java:org.apache.ofbiz.common.CommonEvents#jsResponseFromRequest] from [request], result is [success]
2020-08-10 18:42:17,718 |jsse-nio-8443-exec-7 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:17,719 |jsse-nio-8443-exec-7 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Done- total:0.005,since last([webtools::getJs ...):0.005]]
2020-08-10 18:42:32,567 |sse-nio-8443-exec-10 |ControlServlet |T| [[[webtools::runService (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:32,597 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.0s, 0 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-08-10 18:42:32,597 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.01s, 51 requests, 21 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-08-10 18:42:32,608 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.0s, 26 requests, 10 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/portal-controller.xml
2020-08-10 18:42:32,619 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.0s, 30 requests, 13 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/security-controller.xml
2020-08-10 18:42:32,629 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.0s, 5 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/tempexpr-controller.xml
2020-08-10 18:42:32,630 |sse-nio-8443-exec-10 |ConfigXMLReader |I| controller loaded: 0.053s, 121 requests, 79 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/webapp/webtools/WEB-INF/controller.xml
2020-08-10 18:42:32,633 |sse-nio-8443-exec-10 |RequestHandler |I| Rendering View [runService]. Hidden sessionId by default.
2020-08-10 18:42:32,642 |sse-nio-8443-exec-10 |ScreenFactory |I| Got 12 screens in 0.005s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/ServiceScreens.xml
2020-08-10 18:42:32,871 |sse-nio-8443-exec-10 |ScreenFactory |I| Got 11 screens in 0.004s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/CommonScreens.xml
2020-08-10 18:42:32,876 |sse-nio-8443-exec-10 |ScreenFactory |I| Got 26 screens in 0.004s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-08-10 18:42:33,007 |sse-nio-8443-exec-10 |ScreenFactory |I| Got 25 screens in 0.022s from: file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-08-10 18:42:33,041 |sse-nio-8443-exec-10 |ModelService |I| Set default value [SECURITY] for parameter [primaryPermission]
2020-08-10 18:42:33,048 |sse-nio-8443-exec-10 |Log |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This simple-method-call is deprecated! Please use a service-call of genericBasePermissionC
heck instead.
2020-08-10 18:42:33,108 |sse-nio-8443-exec-10 |ServiceDispatcher |T| Sync service [webtools/genericBasePermissionCheck] finished in [60] milliseconds
2020-08-10 18:42:33,108 |sse-nio-8443-exec-10 |ServiceDispatcher |T| Sync service [webtools/securityPermissionCheck] finished in [67] milliseconds
2020-08-10 18:42:33,134 |sse-nio-8443-exec-10 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:33,136 |sse-nio-8443-exec-10 |ControlServlet |T| [[[webtools::runService (Domain:https://localhost)] Request Done- total:0.569,since last([webtools::runSer...):0.569]]
2020-08-10 18:42:35,852 |jsse-nio-8443-exec-8 |ControlServlet |T| [[[webtools::setSyncServiceParameters (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:35,856 |jsse-nio-8443-exec-8 |RequestHandler |I| Rendering View [setSyncServiceParameters]. Hidden sessionId by default.
2020-08-10 18:42:35,857 |jsse-nio-8443-exec-8 |ServiceDispatcher |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] milliseconds
2020-08-10 18:42:35,879 |jsse-nio-8443-exec-8 |ModelService |I| Set default value [SECURITY] for parameter [primaryPermission]
2020-08-10 18:42:35,880 |jsse-nio-8443-exec-8 |Log |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This simple-method-call is deprecated! Please use a service-call of genericBasePermissionC
heck instead.
2020-08-10 18:42:35,881 |jsse-nio-8443-exec-8 |ServiceDispatcher |T| Sync service [webtools/genericBasePermissionCheck] finished in [1] milliseconds
2020-08-10 18:42:35,881 |jsse-nio-8443-exec-8 |ServiceDispatcher |T| Sync service [webtools/securityPermissionCheck] finished in [2] milliseconds
2020-08-10 18:42:35,896 |jsse-nio-8443-exec-8 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:35,899 |jsse-nio-8443-exec-8 |ControlServlet |T| [[[webtools::setSyncServiceParameters (Domain:https://localhost)] Request Done- total:0.047,since last([webtools::setSyn...):0.047]]
2020-08-10 18:42:36,634 |jsse-nio-8443-exec-9 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:36,637 |jsse-nio-8443-exec-9 |RequestHandler |I| [RequestHandler.doRequest]: Response is a chained request. Hidden sessionId by default.
2020-08-10 18:42:36,637 |jsse-nio-8443-exec-9 |RequestHandler |I| [RequestHandler]: Chain in place: requestUri=js overrideViewUri=null Hidden sessionId by default.
2020-08-10 18:42:36,638 |jsse-nio-8443-exec-9 |RequestHandler |I| Ran Event [java:org.apache.ofbiz.common.CommonEvents#jsResponseFromRequest] from [request], result is [success]
2020-08-10 18:42:36,639 |jsse-nio-8443-exec-9 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:36,640 |jsse-nio-8443-exec-9 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Done- total:0.006,since last([webtools::getJs ...):0.006]]
2020-08-10 18:42:55,949 |jsse-nio-8443-exec-1 |ControlServlet |T| [[[webtools::scheduleServiceSync (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:55,980 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.0s, 0 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-08-10 18:42:55,981 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.01s, 51 requests, 21 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-08-10 18:42:55,990 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.0s, 26 requests, 10 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/portal-controller.xml
2020-08-10 18:42:55,999 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.0s, 30 requests, 13 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/security-controller.xml
2020-08-10 18:42:56,008 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.0s, 5 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/tempexpr-controller.xml
2020-08-10 18:42:56,009 |jsse-nio-8443-exec-1 |ConfigXMLReader |I| controller loaded: 0.048s, 121 requests, 79 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/webapp/webtools/WEB-INF/controller.xml
2020-08-10 18:42:56,096 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/partyContactMechPermissionCheck] finished in [83] milliseconds
2020-08-10 18:42:56,311 |jsse-nio-8443-exec-1 |UtilProperties |I| ResourceBundle ServiceUiLabels (fr) created in 0.036s with 4 properties
2020-08-10 18:42:56,311 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/createContactMech] finished in [52] milliseconds
2020-08-10 18:42:56,416 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/createPostalAddress] finished in [310] milliseconds
2020-08-10 18:42:56,750 |jsse-nio-8443-exec-1 |UtilProperties |I| ResourceBundle PartyEntityLabels (fr) created in 0.087s with 290 properties
2020-08-10 18:42:56,756 |jsse-nio-8443-exec-1 |Log |I| [PartyContactMechServices.xml#createPartyContactMech line 62] Creating a PartyContactMech with id: 111111
2020-08-10 18:42:56,778 |jsse-nio-8443-exec-1 |ServiceEcaCondition |W| doRealCompare returned null, returning false
2020-08-10 18:42:56,778 |jsse-nio-8443-exec-1 |ServiceEcaRule |I| For Service ECA [createPartyContactMech] on [commit] got false for condition: [contactMechPurposeTypeId][is-not-empty][true][String]
2020-08-10 18:42:56,778 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/createPartyContactMech] finished in [362] milliseconds
2020-08-10 18:42:56,778 |jsse-nio-8443-exec-1 |ServiceEcaCondition |W| doRealCompare returned null, returning false
2020-08-10 18:42:56,778 |jsse-nio-8443-exec-1 |ServiceEcaRule |I| For Service ECA [createPartyPostalAddress] on [commit] got false for condition: [paymentMethodId][is-not-empty][true][String]
2020-08-10 18:42:56,779 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/createPartyPostalAddress] finished in [766] milliseconds
2020-08-10 18:42:56,779 |jsse-nio-8443-exec-1 |RequestHandler |I| Ran Event [java:org.apache.ofbiz.webapp.event.CoreEvents#scheduleService] from [request], result is [sync_success]
2020-08-10 18:42:56,779 |jsse-nio-8443-exec-1 |RequestHandler |I| Rendering View [serviceResult]. Hidden sessionId by default.
2020-08-10 18:42:56,781 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] milliseconds
2020-08-10 18:42:56,789 |jsse-nio-8443-exec-1 |ScreenFactory |I| Got 12 screens in 0.005s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/ServiceScreens.xml
2020-08-10 18:42:56,922 |jsse-nio-8443-exec-1 |ScreenFactory |I| Got 11 screens in 0.004s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/webtools/widget/CommonScreens.xml
2020-08-10 18:42:56,927 |jsse-nio-8443-exec-1 |ScreenFactory |I| Got 26 screens in 0.004s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-08-10 18:42:57,057 |jsse-nio-8443-exec-1 |ScreenFactory |I| Got 25 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-08-10 18:42:57,093 |jsse-nio-8443-exec-1 |ModelService |I| Set default value [SECURITY] for parameter [primaryPermission]
2020-08-10 18:42:57,099 |jsse-nio-8443-exec-1 |Log |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This simple-method-call is deprecated! Please use a service-call of genericBasePermissionC
heck instead.
2020-08-10 18:42:57,172 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/genericBasePermissionCheck] finished in [73] milliseconds
2020-08-10 18:42:57,173 |jsse-nio-8443-exec-1 |ServiceDispatcher |T| Sync service [webtools/securityPermissionCheck] finished in [80] milliseconds
2020-08-10 18:42:57,188 |jsse-nio-8443-exec-1 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:57,200 |jsse-nio-8443-exec-1 |ControlServlet |T| [[[webtools::scheduleServiceSync (Domain:https://localhost)] Request Done- total:1.251,since last([webtools::schedu...):1.251]]
2020-08-10 18:42:57,951 |jsse-nio-8443-exec-2 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-10 18:42:57,953 |jsse-nio-8443-exec-2 |RequestHandler |I| [RequestHandler.doRequest]: Response is a chained request. Hidden sessionId by default.
2020-08-10 18:42:57,954 |jsse-nio-8443-exec-2 |RequestHandler |I| [RequestHandler]: Chain in place: requestUri=js overrideViewUri=null Hidden sessionId by default.
2020-08-10 18:42:57,954 |jsse-nio-8443-exec-2 |RequestHandler |I| Ran Event [java:org.apache.ofbiz.common.CommonEvents#jsResponseFromRequest] from [request], result is [success]
2020-08-10 18:42:57,954 |jsse-nio-8443-exec-2 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-08-10 18:42:57,955 |jsse-nio-8443-exec-2 |ControlServlet |T| [[[webtools::getJs (Domain:https://localhost)] Request Done- total:0.004,since last([webtools::getJs ...):0.004]]
```
I did not test the other services.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] hg-stolle commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
hg-stolle commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-677674411
@JacquesLeRoux: Thank you for the quick reply and for looking into it. 😃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux edited a comment on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-677665312
Hi hg-stolle,
Since createPartyPostalAddress is OK, I assume createFacilityPostalAddress and updateFacilityPostalAddress are OK too (did not check).
cdyneReturnCityState is indeed failing but this is an USA specific service and I'd not care about that if USA users are not.
I have still to check if applying this changes does not introduce issues and I'll do very soon...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-850808960
Hi Daniel,
Please test and confirm OFBIZ-12247 is OK with you, TIA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org