You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/01/06 09:20:36 UTC

[GitHub] [nifi] pvillard31 commented on pull request #4578: NIFI-7889 - ConsumeMQTT - use offer instead of add

pvillard31 commented on pull request #4578:
URL: https://github.com/apache/nifi/pull/4578#issuecomment-755183678


   Thanks for the review @turcsanyip - I updated the PR to address your comments. Also, after a discussion with @markap14, I decided to not expose the max offer time as a property and just use the magic number of '1 second' instead. Exposing the property could potentially offer the possibility for users to have a weird configuration leading to weird behaviours. Instead I added an additionalDetails page to still have the explanation around the processor's behavior.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org